From: Paolo Abeni <pabeni@redhat.com>
To: Mat Martineau <mathew.j.martineau@linux.intel.com>,
Matthieu Baerts <matthieu.baerts@tessares.net>
Cc: geliangtang@gmail.com, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-net] mptcp: Only send extra TCP acks in eligible socket states
Date: Tue, 31 Aug 2021 09:21:37 +0200 [thread overview]
Message-ID: <4791c24b4b6003ee52998b8af2d6b30576ba9782.camel@redhat.com> (raw)
In-Reply-To: <4f65e83-3f44-15a7-a9b8-95b4d74b745d@linux.intel.com>
On Mon, 2021-08-30 at 11:10 -0700, Mat Martineau wrote:
> On Thu, 26 Aug 2021, Matthieu Baerts wrote:
>
> > Hi Mat, Paolo,
> >
> > On 26/08/2021 02:46, Mat Martineau wrote:
> > > Recent changes exposed a bug where specifically-timed requests to the
> > > path manager netlink API could trigger a divide-by-zero in
> > > __tcp_select_window(), as syzkaller does:
> >
> > (...)
> >
> > Thank you for the patch, the review and the testing!
> >
>
> More info on the testing: I was able to run syzkaller over the weekend,
> and the error has not reoccurred in the last 5 days.
>
> > This is now in our tree:
> >
> > - ea8a43942429: mptcp: Only send extra TCP acks in eligible socket states
> > - Results: 99a16463048d..6d52100ab2ab
> >
> > > Fixes: 84dfe3677a6f ("mptcp: send out dedicated ADD_ADDR packet")
> > > Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/229
> > > Co-developed-by: Paolo Abeni <pabeni@redhat.com>
> >
> > Checkpatch is yelling at me because a SoB is not present here.
> >
> > @Paolo: sorry to ask this question but for the record, is it OK for you
> > if I add it? :)
> >
>
> Still an open question here about signoff (or changing author header) for
> Paolo !
Yup, sorry, I thought I answered during the mtg. Whatever fits you, is
ok for me.
Cheers,
Paolo
next prev parent reply other threads:[~2021-08-31 7:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 0:46 [PATCH mptcp-net] mptcp: Only send extra TCP acks in eligible socket states Mat Martineau
2021-08-26 18:24 ` Matthieu Baerts
2021-08-30 18:10 ` Mat Martineau
2021-08-31 7:21 ` Paolo Abeni [this message]
2021-08-31 9:46 ` Paolo Abeni
2021-08-31 10:42 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4791c24b4b6003ee52998b8af2d6b30576ba9782.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=geliangtang@gmail.com \
--cc=mathew.j.martineau@linux.intel.com \
--cc=matthieu.baerts@tessares.net \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).