mptcp.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: Matthieu Baerts <matthieu.baerts@tessares.net>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-net v2 0/2] mptcp: ADD_ADDR and fully_estab
Date: Mon, 16 Aug 2021 16:53:57 -0700 (PDT)	[thread overview]
Message-ID: <4c6a722-d7c6-64d8-ddf-cb8d869c342c@linux.intel.com> (raw)
In-Reply-To: <20210816172548.2339984-1-matthieu.baerts@tessares.net>

On Mon, 16 Aug 2021, Matthieu Baerts wrote:

> This is the v2 of "mptcp: full fully established support after ADD_ADDR"
> but now we also make sure the HMAC bit is present (patch 1/2, as
> suggested by Mat, thanks!).
>
> Matthieu Baerts (2):
>  mptcp: check for HMAC presence in ADD_ADDR
>  mptcp: full fully established support after ADD_ADDR
>
> net/mptcp/options.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> -- 
> 2.32.0

Thanks for the v2.

I'd prefer that these are squashed, I don't think it's important to change 
the single line in patch 1 that just gets deleted in patch 2. It wasn't my 
intent to ask for two patches in my previous review, if that was a factor.

Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

--
Mat Martineau
Intel

  parent reply	other threads:[~2021-08-16 23:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-16 17:25 [PATCH mptcp-net v2 0/2] mptcp: ADD_ADDR and fully_estab Matthieu Baerts
2021-08-16 17:25 ` [PATCH mptcp-net v2 1/2] mptcp: check for HMAC presence in ADD_ADDR Matthieu Baerts
2021-08-16 17:25 ` [PATCH mptcp-net v2 2/2] mptcp: full fully established support after ADD_ADDR Matthieu Baerts
2021-08-16 23:53 ` Mat Martineau [this message]
2021-08-17  6:48   ` [PATCH mptcp-net v2 0/2] mptcp: ADD_ADDR and fully_estab Matthieu Baerts
2021-08-17 14:39     ` Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c6a722-d7c6-64d8-ddf-cb8d869c342c@linux.intel.com \
    --to=mathew.j.martineau@linux.intel.com \
    --cc=matthieu.baerts@tessares.net \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).