Re: [RFC PATCH mptcp-next v7 02/11] add mptcp_stream_connect to protocol.h

[Dmytro Shytyi <dmytro@shytyi.net>]

Commit message was changed in v8.

Best,

Dmytro

On 9/19/2022 12:19 PM, Paolo Abeni wrote:
> On Sun, 2022-09-18 at 00:28 +0200, Dmytro Shytyi wrote:
>> We call mptcp_stream_connect() from mptcp_sendmsg_fastopen() in
> Minor nit: the commit message should be changed to something alike:
>
> """
> In the following patches we will call mptcp_stream_connect() [...],
> make such symbol visible.
> """
>
> Otherwise other reviewer may be confused.
>
> Thanks!
>
> Paolo
>
>> fastopen.c
>>
>> Signed-off-by: Dmytro Shytyi <dmytro@shytyi.net>
>> ---
>>   net/mptcp/protocol.c | 4 ++--
>>   net/mptcp/protocol.h | 1 +
>>   2 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
>> index 55442df8fb97..0e5db0a634d3 100644
>> --- a/net/mptcp/protocol.c
>> +++ b/net/mptcp/protocol.c
>> @@ -3474,8 +3474,8 @@ static void mptcp_subflow_early_fallback(struct mptcp_sock *msk,
>>   	__mptcp_do_fallback(msk);
>>   }
>>   
>> -static int mptcp_stream_connect(struct socket *sock, struct sockaddr *uaddr,
>> -				int addr_len, int flags)
>> +int mptcp_stream_connect(struct socket *sock, struct sockaddr *uaddr,
>> +			 int addr_len, int flags)
>>   {
>>   	struct mptcp_sock *msk = mptcp_sk(sock->sk);
>>   	struct mptcp_subflow_context *subflow;
>> diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h
>> index 1bc9f6e77ddd..1e21293bceaa 100644
>> --- a/net/mptcp/protocol.h
>> +++ b/net/mptcp/protocol.h
>> @@ -835,6 +835,7 @@ void mptcp_event(enum mptcp_event_type type, const struct mptcp_sock *msk,
>>   void mptcp_event_addr_announced(const struct sock *ssk, const struct mptcp_addr_info *info);
>>   void mptcp_event_addr_removed(const struct mptcp_sock *msk, u8 id);
>>   bool mptcp_userspace_pm_active(const struct mptcp_sock *msk);
>> +int mptcp_stream_connect(struct socket *sock, struct sockaddr *uaddr, int addr_len, int flags);
>>   
>>   static inline bool mptcp_pm_should_add_signal(struct mptcp_sock *msk)
>>   {