From: Paolo Abeni <pabeni@redhat.com>
To: mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next 1/2] Squash-to: "mptcp: move msk input path under full msk socket lock"
Date: Wed, 24 Aug 2022 14:38:07 +0200 [thread overview]
Message-ID: <73d8018455cc933f99d4a5f53339b0e1b4a7ed12.camel@redhat.com> (raw)
In-Reply-To: <30ec171851daca06e3c3a60a1d3e41ff5887eae2.1661339834.git.pabeni@redhat.com>
On Wed, 2022-08-24 at 13:18 +0200, Paolo Abeni wrote:
> whoops, I forgot to really test for pending data at release_cb time.
>
> The above causes several recurring failures in the self-tests.
>
> Note that this could affect badly the mptcp performance (as we now
> really move relevant CPU time from the subflow rx path/ksoftirqd to
> the user-space process), even if I haven't performed perf-tests yet
> on top of this change.
The first raw number are quite discouraging :/
-30% on single subflow test.
/P
next prev parent reply other threads:[~2022-08-24 12:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 11:18 [PATCH mptcp-next 0/2] mptcp: rx path refactor follow-ups Paolo Abeni
2022-08-24 11:18 ` [PATCH mptcp-next 1/2] Squash-to: "mptcp: move msk input path under full msk socket lock" Paolo Abeni
2022-08-24 12:38 ` Paolo Abeni [this message]
2022-08-24 11:18 ` [PATCH mptcp-next 2/2] mptcp: never re-inject data on a single subflow Paolo Abeni
2022-08-24 13:00 ` mptcp: never re-inject data on a single subflow: Tests Results MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73d8018455cc933f99d4a5f53339b0e1b4a7ed12.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).