mptcp.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: Kishen Maloor <kishen.maloor@intel.com>, Paolo Abeni <pabeni@redhat.com>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-net 0/2] mptcp: support MP_PRIO signals with userspace PMs
Date: Wed, 22 Jun 2022 15:44:38 -0700 (PDT)	[thread overview]
Message-ID: <77ba5fc9-7f13-d67e-621b-305ff26e58a9@linux.intel.com> (raw)
In-Reply-To: <20220622175547.289717-1-kishen.maloor@intel.com>

On Wed, 22 Jun 2022, Kishen Maloor wrote:

> This patch series updates MPTCP_PM_CMD_SET_FLAGS to allow userspace PMs
> to issue MP_PRIO signals for a specified address ID over a chosen
> MPTCP connection. It also adds self testing support for this change.
>
> Kishen Maloor (2):
>  mptcp: netlink: issue MP_PRIO signals from userspace PMs
>  selftests: mptcp: userspace PM support for MP_PRIO signals
>
> net/mptcp/pm_netlink.c                        | 23 ++++++++++----
> net/mptcp/pm_userspace.c                      | 30 ++++++++++++++++++
> net/mptcp/protocol.h                          |  6 +++-
> tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 19 ++++++++++--
> .../selftests/net/mptcp/userspace_pm.sh       | 31 +++++++++++++++++++
> 5 files changed, 100 insertions(+), 9 deletions(-)
>
>
> base-commit: 68fec8b7f640037e4bf224ca4e924574098f5911
> --
> 2.31.1

Thanks Kishen!

The selftest passed on my test system, but I have one comment on that 
patch.

Paolo, do agree this is best sent to the -net branch? This is an important 
chunk of the userspace PM that we accidentally overlooked, and it seems 
pretty important to get in to 5.19.

--
Mat Martineau
Intel

  parent reply	other threads:[~2022-06-22 22:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-22 17:55 [PATCH mptcp-net 0/2] mptcp: support MP_PRIO signals with userspace PMs Kishen Maloor
2022-06-22 17:55 ` [PATCH mptcp-net 1/2] mptcp: netlink: issue MP_PRIO signals from " Kishen Maloor
2022-06-22 17:55 ` [PATCH mptcp-net 2/2] selftests: mptcp: userspace PM support for MP_PRIO signals Kishen Maloor
2022-06-22 20:03   ` selftests: mptcp: userspace PM support for MP_PRIO signals: Tests Results MPTCP CI
2022-06-22 22:48   ` [PATCH mptcp-net 2/2] selftests: mptcp: userspace PM support for MP_PRIO signals Mat Martineau
2022-06-22 22:44 ` Mat Martineau [this message]
2022-06-22 22:46   ` [PATCH mptcp-net 0/2] mptcp: support MP_PRIO signals with userspace PMs Mat Martineau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77ba5fc9-7f13-d67e-621b-305ff26e58a9@linux.intel.com \
    --to=mathew.j.martineau@linux.intel.com \
    --cc=kishen.maloor@intel.com \
    --cc=mptcp@lists.linux.dev \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).