From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Kishen Maloor <kishen.maloor@intel.com>, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-net v4 0/2] mptcp: support MP_PRIO signals with userspace PMs
Date: Wed, 29 Jun 2022 09:03:53 -0700 (PDT) [thread overview]
Message-ID: <7f39b3d3-3681-48cf-d656-a778c7a367eb@linux.intel.com> (raw)
In-Reply-To: <9bfd377923a2c200ff8be000dcbe6b378504f8bd.camel@redhat.com>
On Wed, 29 Jun 2022, Paolo Abeni wrote:
> On Tue, 2022-06-28 at 20:37 -0700, Mat Martineau wrote:
>> On Tue, 28 Jun 2022, Kishen Maloor wrote:
>>
>>> This patch series updates MPTCP_PM_CMD_SET_FLAGS to allow userspace PMs
>>> to issue MP_PRIO signals over a selected (by local and remote address+port)
>>> subflow in a MPTCP connection. It also adds self tests for this
>>> change.
>>>
>>> This patch series has been rebased to the series (in review) titled
>>> "Locking fixes for subflow flag changes".
>>>
>>> v2:
>>> -userspace_pm.sh: added a sleep after issuing the MP_PRIO signal.
>>>
>>> v3:
>>> -use local and remote address+port (instead of address ID) alongwith the
>>> connection token to select a subflow.
>>>
>>> v4:
>>> -fixed bug during rebase in v3.
>>
>> Thanks Kishen. v4 looks good to me, and the builds look good (I pushed
>> equivalent commits to github to trigger a build):
>>
>> https://cirrus-ci.com/build/6289402744799232
>> https://github.com/multipath-tcp/mptcp_net-next/runs/7103422638
>>
>> Looks like the github action got a little confused by the exact version of
>> the patches not being in patchwork.
>>
>>
>> Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
>>
>> At the meeting last week Paolo said he was planning to take a look as
>> well.
>
> LGTM, too.
>
> Acked-by: Paolo Abeni <pabeni@redhat.com>
>
Thanks for the ack.
As Kishen noted above, this series depends on "Locking fixes for subflow
flag changes" - have you had a chance to look at that one? Like I
mentioned in the other thread, it's almost a match for your locking
changes in the RFC MPC MP_PRIO series.
--
Mat Martineau
Intel
next prev parent reply other threads:[~2022-06-29 16:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 1:27 [PATCH mptcp-net v4 0/2] mptcp: support MP_PRIO signals with userspace PMs Kishen Maloor
2022-06-29 1:27 ` [PATCH mptcp-net v4 1/2] mptcp: netlink: issue MP_PRIO signals from " Kishen Maloor
2022-06-29 1:27 ` [PATCH mptcp-net v4 2/2] selftests: mptcp: userspace PM support for MP_PRIO signals Kishen Maloor
2022-06-29 3:37 ` [PATCH mptcp-net v4 0/2] mptcp: support MP_PRIO signals with userspace PMs Mat Martineau
2022-06-29 10:16 ` Paolo Abeni
2022-06-29 16:03 ` Mat Martineau [this message]
2022-06-30 17:46 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f39b3d3-3681-48cf-d656-a778c7a367eb@linux.intel.com \
--to=mathew.j.martineau@linux.intel.com \
--cc=kishen.maloor@intel.com \
--cc=mptcp@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).