From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: Florian Westphal <fw@strlen.de>, mptcp@lists.linux.dev
Cc: mathew.j.martineau@linux.intel.com,
Paolo Abeni <pabeni@redhat.com>, Xiumei Mu <xmu@redhat.com>
Subject: Re: [PATCH v2 mptcp] selftests: mptcp: make sendfile selftest work
Date: Wed, 3 Aug 2022 18:34:38 +0200 [thread overview]
Message-ID: <8ab4af57-e618-19ec-0cc5-1590612bacfc@tessares.net> (raw)
In-Reply-To: <20220729095550.3040-1-fw@strlen.de>
Hi Florian, Mat,
On 29/07/2022 11:55, Florian Westphal wrote:
> When the selftest got added, sendfile() on mptcp sockets returned
> -EOPNOTSUPP, so running 'mptcp_connect.sh -m sendfile' failed
> immediately.
>
> This is no longer the case, but the script fails anyway due to timeout.
> Let the receiver know once the sender has sent all data, just like
> with '-m mmap' mode.
>
> v2: need to respect cfg_wait too, as pm_userspace.sh relied
> on -m sendfile to keep the connection open (Mat Martineau)
Thank you for the patch and the review!
Now in our tree (fix for -net) with Mat's RvB tag:
New patches for t/upstream-net:
- febacb9a6dd6: selftests: mptcp: make sendfile selftest work
- Results: 17273797344c..06a049f34010 (export-net)
New patches for t/upstream:
- febacb9a6dd6: selftests: mptcp: make sendfile selftest work
- Results: ba0f79895fde..7f8f198f2f9b (export)
Tests are now in progress:
https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export-net/20220803T163309
https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20220803T163309
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
prev parent reply other threads:[~2022-08-03 16:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 9:55 [PATCH v2 mptcp] selftests: mptcp: make sendfile selftest work Florian Westphal
2022-07-29 11:20 ` selftests: mptcp: make sendfile selftest work: Tests Results MPTCP CI
2022-07-29 18:07 ` [PATCH v2 mptcp] selftests: mptcp: make sendfile selftest work Mat Martineau
2022-07-29 21:20 ` Florian Westphal
2022-08-03 16:34 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ab4af57-e618-19ec-0cc5-1590612bacfc@tessares.net \
--to=matthieu.baerts@tessares.net \
--cc=fw@strlen.de \
--cc=mathew.j.martineau@linux.intel.com \
--cc=mptcp@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=xmu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).