Re: [PATCH mptcp-next v4 3/3] selftests: mptcp: update and extend fastclose test-cases

[Matthieu Baerts <matthieu.baerts@tessares.net>]

Hi Paolo,

On 09/09/2022 10:49, Paolo Abeni wrote:
> After the previous patches, the MPTCP protocol can generate
> fast-closes on both ends of the connection. Rework the relevant
> test-case to carefully trigger the fast-close code-path on a
> single end at the time, while ensuring than a predictable amount
> of data is spooled on both ends.
> 
> Additionally add another test-cases for the passive socket
> fast-close.

Thank you for the v4!

The whole series looks good to me.

Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>


I wanted to apply it but I just realised that like with the previous
version Patchew didn't apply this v4 as well. Maybe because there is no
cover-letter?

I just applied these patches manually and I will wait for the CI to send
its report before applying them.

https://github.com/multipath-tcp/mptcp_net-next/commits/patchew/904c47ce96fa8d6d4c961a2480bf3aea702c3a9c.1662713367.git.pabeni@redhat.com

(...)

> diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.c b/tools/testing/selftests/net/mptcp/mptcp_connect.c
> index 24d4e9cb617e..7e4ce3caa5ed 100644
> --- a/tools/testing/selftests/net/mptcp/mptcp_connect.c
> +++ b/tools/testing/selftests/net/mptcp/mptcp_connect.c
> @@ -72,6 +72,8 @@ static int cfg_wait;
>  static uint32_t cfg_mark;
>  static char *cfg_input;
>  static int cfg_repeat = 1;
> +static int cfg_truncate;
> +static int cfg_rcv_trunc;
>  
>  struct cfg_cmsg_types {
>  	unsigned int cmsg_enabled:1;
> @@ -95,11 +97,15 @@ static struct cfg_sockopt_types cfg_sockopt_types;
>  
>  static void die_usage(void)
>  {
> -	fprintf(stderr, "Usage: mptcp_connect [-6] [-c cmsg] [-i file] [-I num] [-j] [-l] "
> +	fprintf(stderr, "Usage: mptcp_connect [-6] [-c cmsg] [-f offset] [-i file] [-I num] [-j] [-l] "
>  		"[-m mode] [-M mark] [-o option] [-p port] [-P mode] [-j] [-l] [-r num] "
>  		"[-s MPTCP|TCP] [-S num] [-r num] [-t num] [-T num] [-u] [-w sec] connect_address\n");
>  	fprintf(stderr, "\t-6 use ipv6\n");
>  	fprintf(stderr, "\t-c cmsg -- test cmsg type <cmsg>\n");
> +	fprintf(stderr, "\t-f offset -- stop the I/O after receiving and sending the specified amount "
> +		"of bytes. If there are unread bytes in the receive queue, that will cause a MPTCP "
> +		"fastclose at close/shutdown. If offset is negative, expect the peer to close before "
> +		"all the local data as been sent, thus toleration errors on write and EPIPE signals\n");

Just a small typo here that I can fix when applying (if I don't forget):

  s/as/has/

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net