From: Paolo Abeni <pabeni@redhat.com>
To: Mat Martineau <mathew.j.martineau@linux.intel.com>
Cc: mptcp@lists.linux.dev, fwestpha@redhat.com
Subject: Re: [PATCH mptcp-next 7/7] selftests: mptcp: add testcase for active-back
Date: Fri, 09 Jul 2021 09:04:11 +0200 [thread overview]
Message-ID: <97a1fff6a2619dc3b16700252ea5d0167ec98b6b.camel@redhat.com> (raw)
In-Reply-To: <15d981a-acb3-61c0-1a79-ea703b1db2c9@linux.intel.com>
On Thu, 2021-07-08 at 17:51 -0700, Mat Martineau wrote:
> On Mon, 28 Jun 2021, Paolo Abeni wrote:
>
> > Add more test-case for link failures scenario,
> > including recovery from link failure using only
> > backup subflows and bi-directional transfer.
> >
> > Additionally explicitly check for stale count
> >
>
> I get a lot of intermittent failures due to the expected stale count
> range, like this:
>
> 15 multiple flows, signal, bidirectional, link failure syn[ ok ] - synack[ ok ] - ack[ ok ]
> add[ ok ] - echo [ ok ]
> stale[fail] got 19 stale[s] 18 recover[s], expected stale in range [1..5], stale-recover delta 1
>
> 02 multiple flows, signal, bidirectional, link failure syn[ ok ] - synack[ ok ] - ack[ ok ]
> add[ ok ] - echo [ ok ]
> stale[fail] got 11 stale[s] 10 recover[s], expected stale in range [1..5], stale-recover delta 1
>
> 02 multiple flows, signal, bidirectional, link failure syn[ ok ] - synack[ ok ] - ack[ ok ]
> add[ ok ] - echo [ ok ]
> stale[fail] got 51 stale[s] 50 recover[s], expected stale in range [1..5], stale-recover delta 1
>
>
> and
>
>
> 18 backup subflow in use, bidirectional, link failure syn[ ok ] - synack[ ok ] - ack[ ok ]
> add[ ok ] - echo [ ok ]
> stale[fail] got 8 stale[s] 6 recover[s], expected stale in range [2..4], stale-recover delta 2
>
> 05 backup subflow in use, bidirectional, link failure syn[ ok ] - synack[ ok ] - ack[ ok ]
> add[ ok ] - echo [ ok ]
> stale[fail] got 8 stale[s] 6 recover[s], expected stale in range [2..4], stale-recover delta 2
Ouch, I though I solved these ones :(
I agree not merging before addressing the above. I can't have a look
before next week.
Cheers,
Paolo
next prev parent reply other threads:[~2021-07-09 7:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 15:54 [PATCH mptcp-next 0/7] mptcp: refactor active backup Paolo Abeni
2021-06-28 15:54 ` [PATCH mptcp-next 1/7] mptcp: more accurate timeout Paolo Abeni
2021-06-28 15:54 ` [PATCH mptcp-next 2/7] mptcp: less aggressive retransmission stragegy Paolo Abeni
2021-06-28 15:54 ` [PATCH mptcp-next 3/7] mptcp: handle pending data on closed subflow Paolo Abeni
2021-07-09 0:44 ` Mat Martineau
2021-06-28 15:54 ` [PATCH mptcp-next 4/7] mptcp: faster active backup recovery Paolo Abeni
2021-06-28 15:54 ` [PATCH mptcp-next 5/7] mptcp: add mibs for stale subflows processing Paolo Abeni
2021-06-28 15:54 ` [PATCH mptcp-next 6/7] mptcp: backup flag from incoming MPJ ack option Paolo Abeni
2021-06-28 15:54 ` [PATCH mptcp-next 7/7] selftests: mptcp: add testcase for active-back Paolo Abeni
2021-07-09 0:51 ` Mat Martineau
2021-07-09 7:04 ` Paolo Abeni [this message]
2021-07-09 1:13 ` [PATCH mptcp-next 0/7] mptcp: refactor active backup Mat Martineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97a1fff6a2619dc3b16700252ea5d0167ec98b6b.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=fwestpha@redhat.com \
--cc=mathew.j.martineau@linux.intel.com \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).