From: Martin KaFai Lau <martin.lau@linux.dev>
To: Geliang Tang <geliang@kernel.org>
Cc: Geliang Tang <tanggeliang@kylinos.cn>,
bpf@vger.kernel.org, Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Mykola Lysenko <mykolal@fb.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Shuah Khan <shuah@kernel.org>,
mptcp@lists.linux.dev, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH bpf-next v4 2/3] selftests/bpf: Export send_recv_data helper
Date: Wed, 10 Apr 2024 14:20:00 -0700 [thread overview]
Message-ID: <9d914a95-0d79-44fb-96b8-ca0b34744455@linux.dev> (raw)
In-Reply-To: <a5cfd3271d91756deca82fafbc41f17819b6e67a.1712729342.git.tanggeliang@kylinos.cn>
On 4/9/24 11:13 PM, Geliang Tang wrote:
> +int send_recv_data(int lfd, int fd, uint32_t total_bytes)
> +{
> + ssize_t nr_recv = 0, bytes = 0;
> + struct send_recv_arg arg = {
> + .fd = lfd,
> + .bytes = total_bytes,
> + .stop = 0,
> + };
> + pthread_t srv_thread;
> + void *thread_ret;
> + char batch[1500];
> + int err;
> +
> + err = pthread_create(&srv_thread, NULL, send_recv_server, (void *)&arg);
> + if (err) {
> + log_err("pthread_create");
> + return err;
> + }
> +
> + /* recv total_bytes */
> + while (bytes < total_bytes && !READ_ONCE(arg.stop)) {
> + nr_recv = recv(fd, &batch,
> + MIN(total_bytes - bytes, sizeof(batch)), 0);
> + if (nr_recv == -1 && errno == EINTR)
> + continue;
> + if (nr_recv == -1)
> + break;
> + bytes += nr_recv;
> + }
> +
> + if (bytes != total_bytes) {
> + log_err("recv");
> + return -1;
This is still not right. It needs to write arg.stop and do pthread_join().
pw-bot: cr
> + }
> +
> + WRITE_ONCE(arg.stop, 1);
> + pthread_join(srv_thread, &thread_ret);
> + if (IS_ERR(thread_ret)) {
> + log_err("thread_ret");
> + return -1;
> + }
> +
> + return 0;
> +}
next prev parent reply other threads:[~2024-04-10 21:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 6:13 [PATCH bpf-next v4 0/3] export send_recv_data Geliang Tang
2024-04-10 6:13 ` [PATCH bpf-next v4 1/3] selftests/bpf: Add struct send_recv_arg Geliang Tang
2024-04-10 6:13 ` [PATCH bpf-next v4 2/3] selftests/bpf: Export send_recv_data helper Geliang Tang
2024-04-10 21:20 ` Martin KaFai Lau [this message]
2024-04-10 6:13 ` [PATCH bpf-next v4 3/3] selftests/bpf: Support nonblock for send_recv_data Geliang Tang
2024-04-10 21:34 ` Martin KaFai Lau
2024-04-11 6:52 ` Geliang Tang
2024-04-22 6:50 ` Geliang Tang
2024-04-22 9:45 ` Matthieu Baerts
2024-04-22 10:04 ` Geliang Tang
2024-04-22 10:31 ` Matthieu Baerts
2024-04-22 10:34 ` Geliang Tang
2024-04-22 10:39 ` Matthieu Baerts
2024-04-23 2:58 ` Geliang Tang
2024-05-07 4:04 ` Geliang Tang
2024-04-10 17:53 ` [PATCH bpf-next v4 0/3] export send_recv_data MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d914a95-0d79-44fb-96b8-ca0b34744455@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=geliang@kernel.org \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=mykolal@fb.com \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=tanggeliang@kylinos.cn \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).