mptcp.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Geliang Tang <geliangtang@gmail.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Geliang Tang <geliang.tang@suse.com>, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next] tcp: Add mss zero checks to avoid divide errors
Date: Fri, 23 Sep 2022 10:24:26 +0800	[thread overview]
Message-ID: <CA+WQbwsLPo_XbS-cLe1QhdEj8Ak7Y+as8v6y3FT1Mp3fKd2N5g@mail.gmail.com> (raw)
In-Reply-To: <99b1363eeecf160159bbe9f37e38221e93baef55.camel@redhat.com>

Hi Paolo,

Sorry for the late reply.

Paolo Abeni <pabeni@redhat.com> 于2022年9月9日周五 22:44写道：
>
> On Fri, 2022-09-09 at 20:19 +0800, Geliang Tang wrote:
> > If mss_now is set to zero when invoking tcp_push(), this divide error will occur:
>
> We should not call at all tcp_push() in such situation. How did you
> reproduce the issue?

This does not happen on the export branch, but only when I add the BPF
redundant scheduler.

>
> Adding more check in TCP for the above situation is very likely not the
> correct thing to do. Instead we should prevent MPTCP from reaching for
> tcp_push() in the critical situation.

I agree. Let's just drop this patch. I'll add the new one to avoid
calling tcp_push() in such situation into the " BPF redundant scheduler"
series If we really need it.

Thanks!
-Geliang

>
> Thanks!
>
> Paolo
>
>

      reply	other threads:[~2022-09-23  2:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-09 12:19 [PATCH mptcp-next] tcp: Add mss zero checks to avoid divide errors Geliang Tang
2022-09-09 14:12 ` tcp: Add mss zero checks to avoid divide errors: Tests Results MPTCP CI
2022-09-09 14:44 ` [PATCH mptcp-next] tcp: Add mss zero checks to avoid divide errors Paolo Abeni
2022-09-23  2:24   ` Geliang Tang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+WQbwsLPo_XbS-cLe1QhdEj8Ak7Y+as8v6y3FT1Mp3fKd2N5g@mail.gmail.com \
    --to=geliangtang@gmail.com \
    --cc=geliang.tang@suse.com \
    --cc=mptcp@lists.linux.dev \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).