Hi Davide, Mat,

Mat Martineau <mathew.j.martineau(a)linux.intel.com> 于2021年3月13日周六 上午8:35写道：
>
> On Fri, 12 Mar 2021, Davide Caratti wrote:
>
> > Currently, Linux computes the HMAC contained in ADD_ADDR sub-option using
> > the Address Id and the IP Address, and hardcodes a destination port equal
> > to zero. This is not ok for ADD_ADDR with port: ensure to account for the
> > endpoint port when computing the HMAC, in compliance with RFC8684 §3.4.1.
> >
> > Fixes: 22fb85ffaefb ("mptcp: add port support for ADD_ADDR suboption writing")
> > Signed-off-by: Davide Caratti <dcaratti(a)redhat.com>
> > ---
> > net/mptcp/options.c | 24 ++++++++++++++----------
> > 1 file changed, 14 insertions(+), 10 deletions(-)
> >
>
> Hi Davide -
>
> Thanks for catching this. Fix looks good to me.
>
> Reviewed-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>

Acked-by: Geliang Tang <geliangtang(a)gmail.com>

-Geliang

>
> --
> Mat Martineau
> Intel