mptcp.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Maxim Galaganov <max@internet.ru>
To: Paolo Abeni <pabeni@redhat.com>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next] mptcp: add MIB counter for invalid mapping
Date: Thu, 3 Jun 2021 17:30:07 +0300	[thread overview]
Message-ID: <ae6bfc3a-e6e2-f9aa-ed9f-e5aca04ed65b@internet.ru> (raw)
In-Reply-To: <89666f3fb8f14bbe545f2079794ab78ba24fbbc4.1622720045.git.pabeni@redhat.com>

03.06.2021 16:25, Paolo Abeni пишет:
> Account this exceptional events for better introspection.
> 
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
>   net/mptcp/mib.h     | 1 +
>   net/mptcp/subflow.c | 4 +++-
>   2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/net/mptcp/mib.h b/net/mptcp/mib.h
> index 92e56c0cfbdd..193466c9b549 100644
> --- a/net/mptcp/mib.h
> +++ b/net/mptcp/mib.h
> @@ -18,6 +18,7 @@ enum linux_mptcp_mib_field {
>   	MPTCP_MIB_JOINACKMAC,		/* HMAC was wrong on ACK + MP_JOIN */
>   	MPTCP_MIB_DSSNOMATCH,		/* Received a new mapping that did not match the previous one */
>   	MPTCP_MIB_INFINITEMAPRX,	/* Received an infinite mapping */
> +	MPTCP_MIB_DSSTCPMISMATCH,	/* DSS-mapping did not map with TCP's sequence numbers */

Shouldn't there also be a related change to mptcp_snmp_list in mib.c ?

>   	MPTCP_MIB_DATACSUMERR,		/* The data checksum fail */
>   	MPTCP_MIB_OFOQUEUETAIL,	/* Segments inserted into OoO queue tail */
>   	MPTCP_MIB_OFOQUEUE,		/* Segments inserted into OoO queue */
> diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c
> index 259f99b61c35..ccc07cbab867 100644
> --- a/net/mptcp/subflow.c
> +++ b/net/mptcp/subflow.c
> @@ -1046,8 +1046,10 @@ static enum mapping_status get_mapping_status(struct sock *ssk,
>   	/* we revalidate valid mapping on new skb, because we must ensure
>   	 * the current skb is completely covered by the available mapping
>   	 */
> -	if (!validate_mapping(ssk, skb))
> +	if (!validate_mapping(ssk, skb)) {
> +		MPTCP_INC_STATS(sock_net(ssk), MPTCP_MIB_DSSTCPMISMATCH);
>   		return MAPPING_INVALID;
> +	}
>   
>   	skb_ext_del(skb, SKB_EXT_MPTCP);
>   
> 


  reply	other threads:[~2021-06-03 16:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03 13:25 [PATCH mptcp-next] mptcp: add MIB counter for invalid mapping Paolo Abeni
2021-06-03 14:30 ` Maxim Galaganov [this message]
2021-06-03 14:41   ` Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae6bfc3a-e6e2-f9aa-ed9f-e5aca04ed65b@internet.ru \
    --to=max@internet.ru \
    --cc=mptcp@lists.linux.dev \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).