archive mirror
 help / color / mirror / Atom feed
From: Matthieu Baerts <>
To: Mat Martineau <>
Cc:, Paolo Abeni <>,
	Dan Carpenter <>
Subject: Re: [PATCH mptcp-next] mptcp: fix 'masking a bool' warning
Date: Fri, 25 Jun 2021 17:57:39 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Mat,

On 25/06/2021 17:43, Mat Martineau wrote:
> On Fri, 25 Jun 2021, Matthieu Baerts wrote:
>> Dan Carpenter reported an issue introduced in
>> commit fde56eea01f9 ("mptcp: refine mptcp_cleanup_rbuf") where a new
>> boolean (ack_pending) is masked with 0x9.
>> This is not the intention to ignore values by using a boolean. This
>> variable should have a 'bool' type but we should keep the 'u8' to allow
>            ^^^^^^
>         "should not" ??

Good catch!

>> this comparison.
>> Fixes: fde56eea01f9 ("mptcp: refine mptcp_cleanup_rbuf")
>> Reported-by: Dan Carpenter <>
>> Signed-off-by: Matthieu Baerts <>
> Thanks for catching this Dan!
> I'll send to netdev today. Meanwhile, for the mptcp tree:
> Reviewed-by: Mat Martineau <>

Thank you, just applied in our tree (fix for net-next) without the typo
and with your RvB tag:

- 320bd34a848a: mptcp: fix 'masking a bool' warning

- Results: a12d33111689..28e592bb887e

Builds and tests are now in progress:

Tessares | Belgium | Hybrid Access Solutions

      reply	other threads:[~2021-06-25 15:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25 11:53 Matthieu Baerts
2021-06-25 15:43 ` Mat Martineau
2021-06-25 15:57   ` Matthieu Baerts [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH mptcp-next] mptcp: fix '\''masking a bool'\'' warning' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).