From: Paolo Abeni <pabeni@redhat.com>
To: Geliang Tang <geliangtang@gmail.com>, mptcp@lists.linux.dev
Cc: Geliang Tang <geliangtang@xiaomi.com>
Subject: Re: [MPTCP][PATCH v5 mptcp-next 1/5] mptcp: MP_FAIL suboption sending
Date: Mon, 26 Jul 2021 13:10:42 +0200 [thread overview]
Message-ID: <c41c35969415639a6e09036387ebe170da6b6fa5.camel@redhat.com> (raw)
In-Reply-To: <fce3d982e418e791fc38dd2e9f116de84e429d21.1627281326.git.geliangtang@xiaomi.com>
On Mon, 2021-07-26 at 14:45 +0800, Geliang Tang wrote:
> From: Geliang Tang <geliangtang@xiaomi.com>
>
> This patch added the MP_FAIL suboption sending support.
>
> Add a new flag named send_mp_fail in struct mptcp_subflow_context. If
> this flag is set, send out MP_FAIL suboption.
>
> Add a new member fail_seq in struct mptcp_out_options to save the data
> sequence number to put into the MP_FAIL suboption.
>
> An MP_FAIL option could be included in a RST or on the subflow-level
> ACK.
>
> Signed-off-by: Geliang Tang <geliangtang@xiaomi.com>
> ---
> include/net/mptcp.h | 5 +++-
> net/mptcp/options.c | 61 +++++++++++++++++++++++++++++++++++++++++---
> net/mptcp/protocol.h | 3 +++
> 3 files changed, 64 insertions(+), 5 deletions(-)
>
> diff --git a/include/net/mptcp.h b/include/net/mptcp.h
> index d0b9e4a7121f..6c8c8592153d 100644
> --- a/include/net/mptcp.h
> +++ b/include/net/mptcp.h
> @@ -60,7 +60,10 @@ struct mptcp_out_options {
> u16 suboptions;
> u64 sndr_key;
> u64 rcvr_key;
> - u64 ahmac;
> + union {
> + u64 ahmac;
> + u64 fail_seq;
> + };
> struct mptcp_addr_info local;
> struct mptcp_addr_info remote;
> struct mptcp_rm_list rm_list;
This will conflict with: "mptcp: shrink mptcp_out_options struct". If
this series is merged before the "mptcp: shrink mptcp_out_options
struct" series, I think we can just add the new field here without any
union and do the aliasing the the shirnk' patch.
Otherwise ("mptcp: shrink mptcp_out_options struct" merged first), I
think:
struct mptcp_ext ext_copy;
should be replace with:
struct {
struct mptcp_ext ext_copy;
u64 ahmac;
};
mptcp_out_options should not change size that way.
Cheers
Paolo
next prev parent reply other threads:[~2021-07-26 11:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 6:45 [MPTCP][PATCH v5 mptcp-next 0/5] MP_FAIL support Geliang Tang
2021-07-26 6:45 ` [MPTCP][PATCH v5 mptcp-next 1/5] mptcp: MP_FAIL suboption sending Geliang Tang
2021-07-26 6:45 ` [MPTCP][PATCH v5 mptcp-next 2/5] mptcp: MP_FAIL suboption receiving Geliang Tang
2021-07-26 6:45 ` [MPTCP][PATCH v5 mptcp-next 3/5] mptcp: send out MP_FAIL when data checksum fails Geliang Tang
2021-07-26 6:45 ` [MPTCP][PATCH v5 mptcp-next 4/5] mptcp: add the mibs for MP_FAIL Geliang Tang
2021-07-26 6:45 ` [MPTCP][PATCH v5 mptcp-next 5/5] selftests: mptcp: add MP_FAIL mibs check Geliang Tang
2021-07-26 11:10 ` Paolo Abeni [this message]
2021-07-28 2:43 ` [MPTCP][PATCH v5 mptcp-next 1/5] mptcp: MP_FAIL suboption sending Geliang Tang
2021-07-28 0:27 ` [MPTCP][PATCH v5 mptcp-next 0/5] MP_FAIL support Mat Martineau
2021-07-28 3:04 ` Geliang Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c41c35969415639a6e09036387ebe170da6b6fa5.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=geliangtang@gmail.com \
--cc=geliangtang@xiaomi.com \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).