mptcp.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: Yonglong Li <liyonglong@chinatelecom.cn>
Cc: mptcp@lists.linux.dev, geliangtang@gmail.com
Subject: Re: [PATCH v8 0/4] mptcp: fix conflicts when using pm.add_signal in ADD_ADDR/echo and RM_ADDR process
Date: Fri, 9 Jul 2021 18:00:18 -0700 (PDT)	[thread overview]
Message-ID: <c4a942d7-b086-f18f-c097-609af9451dde@linux.intel.com> (raw)
In-Reply-To: <1625677301-139357-1-git-send-email-liyonglong@chinatelecom.cn>

On Thu, 8 Jul 2021, Yonglong Li wrote:

> fix issue: ADD_ADDR and RM_ADDR use pm.add_signal to mark event, so
> in some case pm.add_signal will be flush when ADD_ADDR/RM_ADDR in
> process.
>
> fix issue: if ADD_ADDR and ADD_ADDR-echo process at the same time,
> only one event can write pm.add_signal. so ADD_ADDR will process
> after add_timer timeout or ADD_ADDR-echo will not be process.
>
> Patch 1 fix ADD_ADDR and RM_ADDR maybe clear addr_signal each other.
>
> Patch 2 and 3 deal ADD_ADDR and ADD_ADDR-echo with separately to fix
> conflicts in using pm.addr_signal porcess.
>
> Patch 4 MPTCP_ADD_ADDR_IPV6 and MPTCP_ADD_ADDR_PORT is not necessary.
>
> v1->v2:
> - remove READ_ONCE under the pm spin lock.
>
> v2->v3:
> - Patch 2: mptcp_pm_should_add_addr => mptcp_pm_should_add_signal_addr
> - Patch 3: avoid read-modify-write of msk->pm.addr_signal and change
>   mptcp_pm_add_addr_signal to return void.
>
> v3->v4:
> - Patch 1: use ~(BIT(MPTCP_ADD_ADDR_SIGNAL) | BIT(MPTCP_ADD_ADDR_ECHO))
>   instead of BIT(MPTCP_RM_ADDR_SIGNAL)
> - Patch 3: simple the code; init flags; fix wrong goto logic code;
>
> v4->v5:
> - Patch 3: simple the code of 'mptcp_established_options_add_addr'
>
> v5->v6:
> - Patch2: fix fails of 'mptcp_join.sh -t'. In mptcp_pm_add_addr_send_ack
>   without MPTCP_ADD_ADDR_SIGNAL check so pure ack can not be sent for
>   ADD_ADDR. That cause ADD_ADDR can not be sent in time.
> - Patch3: refactor some code according Geliang's suggestions.
> - Patch4: modify commit comment
>
> v6->v7:
> - Patch1: use reverse xmas tree order for variables definition
> - Patch3: refactor some code according Geliang's suggestions.
> - add a Patch4: remove some double-check
>
> v7->v8:
> - Patch1,2: exchange patch1 and patch2
> - Patch3: refactor some code according Geliang's suggestions.
> - remove patch "remove some double check", Geliang think it's unnecessary
>
> Yonglong Li (4):
>  mptcp: make MPTCP_ADD_ADDR_SIGNAL and MPTCP_ADD_ADDR_ECHO separate
>  mptcp: fix ADD_ADDR and RM_ADDR maybe flush addr_signal each other
>  mptcp: build ADD_ADDR/echo-ADD_ADDR option according pm.add_signal
>  mptcp: remove MPTCP_ADD_ADDR_IPV6 and MPTCP_ADD_ADDR_PORT
>
> include/net/mptcp.h    |  3 ++-
> net/mptcp/options.c    | 51 +++++++++++++++++++++++++++-----------------------
> net/mptcp/pm.c         | 51 +++++++++++++++++++++++++++++++-------------------
> net/mptcp/pm_netlink.c | 10 ++++------
> net/mptcp/protocol.h   | 44 +++++++++++++++++++++++--------------------
> 5 files changed, 90 insertions(+), 69 deletions(-)
>
> -- 
> 1.8.3.1

Hi Yonglong -

Thanks for your revisions. I don't have any code changes to suggest for 
v8, I think we should add these to the export branch and if any more 
changes are required we can squash those before upstreaming.


--
Mat Martineau
Intel

  parent reply	other threads:[~2021-07-10  1:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-07 17:01 Yonglong Li
2021-07-07 17:01 ` [PATCH v8 1/4] mptcp: make MPTCP_ADD_ADDR_SIGNAL and MPTCP_ADD_ADDR_ECHO separate Yonglong Li
2021-07-07 17:01 ` [PATCH v8 2/4] mptcp: fix ADD_ADDR and RM_ADDR maybe flush addr_signal each other Yonglong Li
2021-07-07 17:01 ` [PATCH v8 3/4] mptcp: build ADD_ADDR/echo-ADD_ADDR option according pm.add_signal Yonglong Li
2021-07-07 17:01 ` [PATCH v8 4/4] mptcp: remove MPTCP_ADD_ADDR_IPV6 and MPTCP_ADD_ADDR_PORT Yonglong Li
2021-07-10  1:00 ` Mat Martineau [this message]
2021-07-11 15:20   ` [PATCH v8 0/4] mptcp: fix conflicts when using pm.add_signal in ADD_ADDR/echo and RM_ADDR process Geliang Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4a942d7-b086-f18f-c097-609af9451dde@linux.intel.com \
    --to=mathew.j.martineau@linux.intel.com \
    --cc=geliangtang@gmail.com \
    --cc=liyonglong@chinatelecom.cn \
    --cc=mptcp@lists.linux.dev \
    --subject='Re: [PATCH v8 0/4] mptcp: fix conflicts when using pm.add_signal in ADD_ADDR/echo and RM_ADDR process' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox