From: Paolo Abeni <pabeni@redhat.com>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Mat Martineau <mathew.j.martineau@linux.intel.com>,
Ayush Sawal <ayush.sawal@chelsio.com>,
Eric Dumazet <edumazet@google.com>,
mptcp@lists.linux.dev
Subject: [RFC PATCH 0/5] net: remove sk skb caches
Date: Fri, 17 Sep 2021 17:38:35 +0200 [thread overview]
Message-ID: <cover.1631888517.git.pabeni@redhat.com> (raw)
Eric noted we would be better off reverting the sk
skb caches.
MPTCP relies on such a feature, so we need a
little refactor of the MPTCP tx path before the mentioned
revert.
The first patch avoids that the next one will cause a name
clash. The second exposes additional TCP helpers. The 3rd patch
changes the MPTCP code to do locally the whole skb allocation
and updating, so it does not rely anymore on core TCP helpers
for that nor the sk skb cache.
As a side effect, we can drop the tcp_build_frag helper.
Finally, we can pull Eric's revert.
Note that patch 3/5 will conflict with the pending -net fix
for a recently reported syzkaller splat.
Eric Dumazet (1):
tcp: remove sk_{tr}x_skb_cache
Paolo Abeni (4):
chtls: rename skb_entail() to chtls_skb_entail()
tcp: expose the tcp_mark_push() and skb_entail() helpers
mptcp: stop relying on tcp_tx_skb_cache
Partially revert "tcp: factor out tcp_build_frag()"
Documentation/networking/ip-sysctl.rst | 8 -
.../chelsio/inline_crypto/chtls/chtls.h | 2 +-
.../chelsio/inline_crypto/chtls/chtls_cm.c | 2 +-
.../chelsio/inline_crypto/chtls/chtls_io.c | 10 +-
include/net/sock.h | 19 ---
include/net/tcp.h | 4 +-
net/ipv4/af_inet.c | 4 -
net/ipv4/sysctl_net_ipv4.c | 12 --
net/ipv4/tcp.c | 147 +++++++-----------
net/ipv4/tcp_ipv4.c | 6 -
net/ipv6/tcp_ipv6.c | 6 -
net/mptcp/protocol.c | 137 +++++++++-------
12 files changed, 139 insertions(+), 218 deletions(-)
--
2.26.3
next reply other threads:[~2021-09-17 15:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 15:38 Paolo Abeni [this message]
2021-09-17 15:38 ` [RFC PATCH 1/5] chtls: rename skb_entail() to chtls_skb_entail() Paolo Abeni
2021-09-17 15:38 ` [RFC PATCH 2/5] tcp: expose the tcp_mark_push() and skb_entail() helpers Paolo Abeni
2021-09-17 16:43 ` Eric Dumazet
2021-09-17 17:28 ` Paolo Abeni
2021-09-17 15:38 ` [RFC PATCH 3/5] mptcp: stop relying on tcp_tx_skb_cache Paolo Abeni
2021-09-17 15:38 ` [RFC PATCH 4/5] Partially revert "tcp: factor out tcp_build_frag()" Paolo Abeni
2021-09-17 16:41 ` Eric Dumazet
2021-09-17 17:31 ` Paolo Abeni
2021-09-17 15:38 ` [RFC PATCH 5/5] tcp: remove sk_{tr}x_skb_cache Paolo Abeni
2021-09-17 16:47 ` [RFC PATCH 0/5] net: remove sk skb caches Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1631888517.git.pabeni@redhat.com \
--to=pabeni@redhat.com \
--cc=ayush.sawal@chelsio.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).