mptcp.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: Paolo Abeni <pabeni@redhat.com>, Florian Westphal <fw@strlen.de>
Cc: mptcp@lists.linux.dev
Subject: Re: [RFC] mptcp: add MPTCP_INFO getsockopt
Date: Fri, 23 Jul 2021 10:56:57 +0200	[thread overview]
Message-ID: <d0e0626d-b564-9e76-b07b-822e02aac291@tessares.net> (raw)
In-Reply-To: <a065d16447194006a098e27238be655c901feef7.camel@redhat.com>

On 23/07/2021 10:49, Paolo Abeni wrote:
> On Thu, 2021-07-22 at 17:01 +0200, Florian Westphal wrote:

(...)

> +1 to pass back the user 2 sizes: one with
> the "this is how much I copied to the buffer" and another with
> "this is how much i would have copied".

+1

>> Alternatively one could overload e.g. the upper 8 bit:
>>
>> getsockopt(fd, SOL_MPTCP, subflow_ids[0] << 24 | SUBFLOW_FOO, ...);
> 
> What about using:
> 
> struct mptcp_subflow_info {
> 	u32 	id;
> 	struct tcp_info info;
> };
> 
> mptcp_subflow_info.id = id;
> getsockopt(fd, SOL_MPTCP, &mptcp_subflow_info, ...);

Indeed, clearer if we can do that :)

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

      reply	other threads:[~2021-07-23  8:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-22 15:01 Florian Westphal
2021-07-22 16:40 ` Matthieu Baerts
2021-07-22 20:53   ` Florian Westphal
2021-07-23  8:49 ` Paolo Abeni
2021-07-23  8:56   ` Matthieu Baerts [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0e0626d-b564-9e76-b07b-822e02aac291@tessares.net \
    --to=matthieu.baerts@tessares.net \
    --cc=fw@strlen.de \
    --cc=mptcp@lists.linux.dev \
    --cc=pabeni@redhat.com \
    --subject='Re: [RFC] mptcp: add MPTCP_INFO getsockopt' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox