mptcp.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: Mat Martineau <mathew.j.martineau@linux.intel.com>,
	mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next] selftests: mptcp: Initialize variables to quiet gcc 12 warnings
Date: Wed, 22 Jun 2022 23:13:15 +0200	[thread overview]
Message-ID: <e7d707c8-9b0c-1366-2245-e3157f82a76b@tessares.net> (raw)
In-Reply-To: <20220622001846.172735-1-mathew.j.martineau@linux.intel.com>

Hi Mat, Paolo,

On 22/06/2022 02:18, Mat Martineau wrote:
> In a few MPTCP selftest tools, gcc 12 complains that the 'sock' variable
> might be used uninitialized. This is a false positive because the only
> code path that could lead to uninitialized access is where getaddrinfo()
> fails, but the local xgetaddrinfo() wrapper exits if such a failure
> occurs.
> 
> Initialize the 'sock' variable anyway to allow the tools to build with
> gcc 12.

Thank you for the patch and the review!

I just applied this patch in our tree (feat. for net-next but maybe it
could go in 'fix for -net' with a 'Fixes' tag, no?) with Paolo's ACK:

New patches for t/upstream:
- 5a3689ec11a3: selftests: mptcp: Initialize variables to quiet gcc 12
warnings
- Results: 8346c4604d29..cbb1cc653035 (export)

Builds and tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20220622T211129
https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

      parent reply	other threads:[~2022-06-22 21:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-22  0:18 [PATCH mptcp-next] selftests: mptcp: Initialize variables to quiet gcc 12 warnings Mat Martineau
2022-06-22  1:46 ` selftests: mptcp: Initialize variables to quiet gcc 12 warnings: Tests Results MPTCP CI
2022-06-22  9:53 ` [PATCH mptcp-next] selftests: mptcp: Initialize variables to quiet gcc 12 warnings Paolo Abeni
2022-06-22 21:13 ` Matthieu Baerts [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7d707c8-9b0c-1366-2245-e3157f82a76b@tessares.net \
    --to=matthieu.baerts@tessares.net \
    --cc=mathew.j.martineau@linux.intel.com \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).