mptcp.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Jianguo Wu <wujianguo106@163.com>
To: Matthieu Baerts <matthieu.baerts@tessares.net>, mptcp@lists.linux.dev
Cc: pabeni@redhat.com, mathew.j.martineau@linux.intel.com,
	Geliang Tang <geliangtang@gmail.com>
Subject: Re: [PATCH mptcp-net v7 4/5] mptcp: avoid processing packet if a subflow reset
Date: Fri, 25 Jun 2021 17:46:08 +0800	[thread overview]
Message-ID: <e8085dfd-9151-049e-cc1e-3267236a1b2d@163.com> (raw)
In-Reply-To: <a3caa434-2e3a-3370-c3d5-466023923436@tessares.net>



On 2021/6/25 17:07, Matthieu Baerts wrote:
> Hi Jianguo,
> 
> Thank you for working on that!
> 
> On 25/06/2021 10:25, wujianguo106@163.com wrote:
>> From: Jianguo Wu <wujianguo@chinatelecom.cn>
>>
>> If check_fully_established() causes a subflow reset, it should not
>> continue to process the packet in tcp_data_queue().
>> Add a return value to mptcp_incoming_options(), and return 0 if a
>> subflow has been reset, else return 1.
> 
> A small detail but it looks strange to me to return +1.
> Maybe clearer to return -1 in case of error or return a boolean?
> 

Hi Mat and Geliang,

Based on your comments, I will use boolean type as return value, return false if a subflow has been reset.
Thanks for your review!

> If you decide to return -1, please check for '< 0':
> 
>   if (mptcp_incoming_options(...) < 0) // error: we discard
>       goto discard;
> 
> and not:
> 
>   if (mptcp_incoming_options(...)) // no error but we discard??
>       goto discard;
> 
> (Or replace subflow_is_rst by subflow_is_accepted and return this
> variable but it might be strange to return that if you don't have a DSS,
> etc.)
> 
> But if it is only me who find "strange" to return 0/+1, fine not to
> change but it looks uncommon and maybe a source of misinterpretation :)
> 
> Cheers,
> Matt
> 


  reply	other threads:[~2021-06-25  9:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25  8:25 [PATCH mptcp-net v7 0/5] Fix some mptcp syncookie process bugs wujianguo106
2021-06-25  8:25 ` [PATCH mptcp-net v7 1/5] mptcp: fix warning in __skb_flow_dissect() when do syn cookie for subflow join wujianguo106
2021-06-25  8:25 ` [PATCH mptcp-net v7 2/5] mptcp: remove redundant req destruct in subflow_check_req() wujianguo106
2021-06-25  8:25 ` [PATCH mptcp-net v7 3/5] mptcp: fix syncookie process if mptcp can not_accept new subflow wujianguo106
2021-06-25  8:25 ` [PATCH mptcp-net v7 4/5] mptcp: avoid processing packet if a subflow reset wujianguo106
2021-06-25  8:58   ` Geliang Tang
2021-06-25  9:07   ` Matthieu Baerts
2021-06-25  9:46     ` Jianguo Wu [this message]
2021-06-26  1:07       ` Mat Martineau
2021-06-25 10:38   ` Paolo Abeni
2021-06-25 10:45   ` Paolo Abeni
2021-06-26  8:59     ` Jianguo Wu
2021-06-25  8:25 ` [PATCH mptcp-net v7 5/5] selftests: mptcp: fix case multiple subflows limited by server wujianguo106

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e8085dfd-9151-049e-cc1e-3267236a1b2d@163.com \
    --to=wujianguo106@163.com \
    --cc=geliangtang@gmail.com \
    --cc=mathew.j.martineau@linux.intel.com \
    --cc=matthieu.baerts@tessares.net \
    --cc=mptcp@lists.linux.dev \
    --cc=pabeni@redhat.com \
    --subject='Re: [PATCH mptcp-net v7 4/5] mptcp: avoid processing packet if a subflow reset' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).