From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: Kishen Maloor <kishen.maloor@intel.com>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-net v2 0/2] mptcp: support MP_PRIO signals with userspace PMs
Date: Thu, 23 Jun 2022 14:32:20 -0700 (PDT) [thread overview]
Message-ID: <efd28e16-67e5-4ef2-ed45-e75e431581aa@linux.intel.com> (raw)
In-Reply-To: <8cab7043-8cc3-eecc-08f-c5e563b8f2e@linux.intel.com>
On Thu, 23 Jun 2022, Mat Martineau wrote:
> On Wed, 22 Jun 2022, Kishen Maloor wrote:
>
>> This patch series updates MPTCP_PM_CMD_SET_FLAGS to allow userspace PMs
>> to issue MP_PRIO signals for a specified address ID over a chosen
>> MPTCP connection. It also adds self testing support for this change.
>>
>> v2:
>> -userspace_pm.sh: added a sleep after issuing the MP_PRIO signal.
>
> Thanks Kishen. v2 looks good to me:
>
> Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
>
I spoke too soon.
I was looking at the multipath-tcp.org API for changing the backup flag
with Ossama, and that netlink command (MPTCP_CMD_SUB_PRIORITY) uses the
local and remote addresses and port numbers rather than the endpoint IDs.
This is so the priority can be changed for an individual subflow. The
API parameters I asked for in issue 286 would only allow priority to be
changed for all subflows using a specific local endpoint, which is not
specific enough.
I'll update https://github.com/multipath-tcp/mptcp_net-next/issues/286
to request a change to the MPTCP_PM_CMD_SET_FLAGS parameters.
>>
>> Kishen Maloor (2):
>> mptcp: netlink: issue MP_PRIO signals from userspace PMs
>> selftests: mptcp: userspace PM support for MP_PRIO signals
>>
>> net/mptcp/pm_netlink.c | 23 +++++++++----
>> net/mptcp/pm_userspace.c | 30 +++++++++++++++++
>> net/mptcp/protocol.h | 6 +++-
>> tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 19 +++++++++--
>> .../selftests/net/mptcp/userspace_pm.sh | 32 +++++++++++++++++++
>> 5 files changed, 101 insertions(+), 9 deletions(-)
>>
>>
>> base-commit: 68fec8b7f640037e4bf224ca4e924574098f5911
>> --
>> 2.31.1
>>
>>
--
Mat Martineau
Intel
prev parent reply other threads:[~2022-06-23 21:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 0:59 [PATCH mptcp-net v2 0/2] mptcp: support MP_PRIO signals with userspace PMs Kishen Maloor
2022-06-23 0:59 ` [PATCH mptcp-net v2 1/2] mptcp: netlink: issue MP_PRIO signals from " Kishen Maloor
2022-06-23 0:59 ` [PATCH mptcp-net v2 2/2] selftests: mptcp: userspace PM support for MP_PRIO signals Kishen Maloor
2022-06-23 2:39 ` selftests: mptcp: userspace PM support for MP_PRIO signals: Tests Results MPTCP CI
2022-06-23 15:02 ` [PATCH mptcp-net v2 0/2] mptcp: support MP_PRIO signals with userspace PMs Mat Martineau
2022-06-23 21:32 ` Mat Martineau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efd28e16-67e5-4ef2-ed45-e75e431581aa@linux.intel.com \
--to=mathew.j.martineau@linux.intel.com \
--cc=kishen.maloor@intel.com \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).