From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: Geliang Tang <geliangtang@gmail.com>
Cc: mptcp@lists.linux.dev
Subject: Re: [MPTCP][PATCH mptcp-next] mptcp: drop unuse rcu in mptcp_pm_addr_entry
Date: Fri, 9 Jul 2021 10:38:29 -0700 (PDT) [thread overview]
Message-ID: <fe2a31fc-6681-f0e9-317f-e1fc48c5b27c@linux.intel.com> (raw)
In-Reply-To: <75536cfb651328a9c8446676ec123b84e5f4c35f.1625829674.git.geliangtang@gmail.com>
On Fri, 9 Jul 2021, Geliang Tang wrote:
> kfree_rcu() had been removed from pm_netlink.c, so this rcu field in
> struct mptcp_pm_addr_entry became useless. Let's drop it.
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
Thanks for spotting this!
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
> ---
> net/mptcp/pm_netlink.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
> index d2591ebf01d9..56263c2c4014 100644
> --- a/net/mptcp/pm_netlink.c
> +++ b/net/mptcp/pm_netlink.c
> @@ -27,7 +27,6 @@ struct mptcp_pm_addr_entry {
> struct mptcp_addr_info addr;
> u8 flags;
> int ifindex;
> - struct rcu_head rcu;
> struct socket *lsk;
> };
>
> --
> 2.31.1
--
Mat Martineau
Intel
next prev parent reply other threads:[~2021-07-09 17:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 11:22 [MPTCP][PATCH mptcp-next] mptcp: drop unuse rcu in mptcp_pm_addr_entry Geliang Tang
2021-07-09 17:38 ` Mat Martineau [this message]
2021-07-16 9:17 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe2a31fc-6681-f0e9-317f-e1fc48c5b27c@linux.intel.com \
--to=mathew.j.martineau@linux.intel.com \
--cc=geliangtang@gmail.com \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).