From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-net] Squash-to: "selftests: mptcp: more stable diag tests"
Date: Wed, 22 Jun 2022 14:10:53 -0700 (PDT) [thread overview]
Message-ID: <ffef409e-3a5-72df-ff5f-7eb63ad3b53@linux.intel.com> (raw)
In-Reply-To: <f1109179c77a14bed80be75bb297aac1ef867a49.1655891188.git.pabeni@redhat.com>
On Wed, 22 Jun 2022, Paolo Abeni wrote:
> The "....chk remote_key" testcase is failing quite often in debug
> build. I guess the mptcp_connect completes before the script execute
> this latter test, so I'm adding another large wait. It should not
> impact the test run-time, as the mptcp_connect processes are terminated
> just after running the check.
>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
> this is wild guess, mostly to trigger/inspect the test results
Looks good to squash - CI looks ok too.
- Mat
> ---
> tools/testing/selftests/net/mptcp/diag.sh | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/testing/selftests/net/mptcp/diag.sh b/tools/testing/selftests/net/mptcp/diag.sh
> index ee2f238255ec..515859a5168b 100755
> --- a/tools/testing/selftests/net/mptcp/diag.sh
> +++ b/tools/testing/selftests/net/mptcp/diag.sh
> @@ -179,7 +179,7 @@ ip -n $ns link set dev lo up
> echo "a" | \
> timeout ${timeout_test} \
> ip netns exec $ns \
> - ./mptcp_connect -p 10000 -l -t ${timeout_poll} \
> + ./mptcp_connect -p 10000 -l -t ${timeout_poll} -w 20 \
> 0.0.0.0 >/dev/null &
> wait_local_port_listen $ns 10000
> chk_msk_nr 0 "no msk on netns creation"
> @@ -188,7 +188,7 @@ chk_msk_listen 10000
> echo "b" | \
> timeout ${timeout_test} \
> ip netns exec $ns \
> - ./mptcp_connect -p 10000 -r 0 -t ${timeout_poll} \
> + ./mptcp_connect -p 10000 -r 0 -t ${timeout_poll} -w 20 \
> 127.0.0.1 >/dev/null &
> wait_connected $ns 10000
> chk_msk_nr 2 "after MPC handshake "
> @@ -200,13 +200,13 @@ flush_pids
> echo "a" | \
> timeout ${timeout_test} \
> ip netns exec $ns \
> - ./mptcp_connect -p 10001 -l -s TCP -t ${timeout_poll} \
> + ./mptcp_connect -p 10001 -l -s TCP -t ${timeout_poll} -w 20 \
> 0.0.0.0 >/dev/null &
> wait_local_port_listen $ns 10001
> echo "b" | \
> timeout ${timeout_test} \
> ip netns exec $ns \
> - ./mptcp_connect -p 10001 -r 0 -t ${timeout_poll} \
> + ./mptcp_connect -p 10001 -r 0 -t ${timeout_poll} -w 20 \
> 127.0.0.1 >/dev/null &
> wait_connected $ns 10001
> chk_msk_fallback_nr 1 "check fallback"
> --
> 2.35.3
>
>
>
--
Mat Martineau
Intel
next prev parent reply other threads:[~2022-06-22 21:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 9:47 [PATCH mptcp-net] Squash-to: "selftests: mptcp: more stable diag tests" Paolo Abeni
2022-06-22 11:52 ` Squash-to: "selftests: mptcp: more stable diag tests": Tests Results MPTCP CI
2022-06-22 21:10 ` Mat Martineau [this message]
2022-06-22 21:16 ` [PATCH mptcp-net] Squash-to: "selftests: mptcp: more stable diag tests" Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffef409e-3a5-72df-ff5f-7eb63ad3b53@linux.intel.com \
--to=mathew.j.martineau@linux.intel.com \
--cc=mptcp@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).