netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Igor Russkikh <Igor.Russkikh@aquantia.com>
To: Oliver Neukum <oneukum@suse.com>,
	Dmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 2/3] aqc111: fix writing to the phy on BE
Date: Wed, 15 May 2019 14:16:11 +0000	[thread overview]
Message-ID: <00719f72-280b-418f-235d-8bf0215d484e@aquantia.com> (raw)
In-Reply-To: <1557839644.11261.4.camel@suse.com>


>>> -	aqc111_write32_cmd(dev, AQ_PHY_OPS, 0, 0, &aqc111_data->phy_cfg);
>>> +	phy_on_the_wire = aqc111_data->phy_cfg;
>>> +	aqc111_write32_cmd(dev, AQ_PHY_OPS, 0, 0, &phy_on_the_wire);
>>
>> Hi Oliver,
>>
>> I see all write32_cmd and write16_cmd are using a temporary variable to do an
>> internal cpu_to_le32. Why this extra temporary storage is needed?
>>
>> The question is actually for both 2nd and third patch.
>> In all the cases BE machine will store temporary bswap conversion in tmp
>> variable and will not actually touch actual field.
> 
> Hi,
> 
> I am most terribly sorry. I overlooked the copy. Shall I revert or will
> you.
> 
> 	Sorry
> 		Oliver

Hi Oliver,

I'll submit the reverts.

Regards,
  Igor

  reply	other threads:[~2019-05-15 14:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-09  9:08 [PATCH 1/3] aqc111: fix endianness issue in aqc111_change_mtu Oliver Neukum
2019-05-09  9:08 ` [PATCH 2/3] aqc111: fix writing to the phy on BE Oliver Neukum
2019-05-09 16:37   ` David Miller
2019-05-14 12:11   ` Igor Russkikh
2019-05-14 13:14     ` Oliver Neukum
2019-05-15 14:16       ` Igor Russkikh [this message]
2019-05-09  9:08 ` [PATCH 3/3] aqc111: fix double endianness swap " Oliver Neukum
2019-05-09 16:37   ` David Miller
2019-05-09 16:37 ` [PATCH 1/3] aqc111: fix endianness issue in aqc111_change_mtu David Miller
2019-05-14 12:37 ` Igor Russkikh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00719f72-280b-418f-235d-8bf0215d484e@aquantia.com \
    --to=igor.russkikh@aquantia.com \
    --cc=Dmitry.Bezrukov@aquantia.com \
    --cc=netdev@vger.kernel.org \
    --cc=oneukum@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).