From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Simon Horman <simon.horman@corigine.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
John Hurley <john.hurley@netronome.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
oss-drivers@corigine.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2 1/2] nfp: flower: Fix a potential leak in nfp_tunnel_add_shared_mac()
Date: Thu, 17 Feb 2022 19:20:30 +0100 [thread overview]
Message-ID: <01035905-61f5-da02-36d5-92831e1da184@wanadoo.fr> (raw)
In-Reply-To: <20220217075940.GA4665@corigine.com>
Le 17/02/2022 à 08:59, Simon Horman a écrit :
> On Fri, Feb 11, 2022 at 04:53:56PM -0800, Jakub Kicinski wrote:
>> On Thu, 10 Feb 2022 23:34:52 +0100 Christophe JAILLET wrote:
>>> ida_simple_get() returns an id between min (0) and max (NFP_MAX_MAC_INDEX)
>>> inclusive.
>>> So NFP_MAX_MAC_INDEX (0xff) is a valid id.
>>>
>>> In order for the error handling path to work correctly, the 'invalid'
>>> value for 'ida_idx' should not be in the 0..NFP_MAX_MAC_INDEX range,
>>> inclusive.
>>>
>>> So set it to -1.
>>>
>>> Fixes: 20cce8865098 ("nfp: flower: enable MAC address sharing for offloadable devs")
>>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>>
>> This patch is a fix and the other one is refactoring. They can't be
>> in the same series because they need to go to different trees. Please
>> repost the former with [PATCH net] and ~one week later the latter with
>> [PATCH net-next].
>
> Thanks Jakub.
>
> Christophe, please let me know if you'd like me to handle reposting
> the patches as described by Jakub.
>
Hi,
If you can, it's fine for me.
I must admit that what I consider, as an hobbyist, too much bureaucracy
is sometimes discouraging.
I do understand the need for maintainers to have things the way they
need, but, well, maybe sometimes it is too much.
In this particular case, maybe patch 1/2 could be applied to net as-is,
and 2/2 just dropped because not really useful.
(Just the thoughts of a tired man after a long day at work, don't worry,
tomorrow, I'll be in a better mood)
CJ
next prev parent reply other threads:[~2022-02-17 18:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 22:34 [PATCH v2 1/2] nfp: flower: Fix a potential leak in nfp_tunnel_add_shared_mac() Christophe JAILLET
2022-02-10 22:35 ` [PATCH v2 2/2] nfp: flower: Remove usage of the deprecated ida_simple_xxx API Christophe JAILLET
2022-02-11 8:13 ` Simon Horman
2022-06-09 5:11 ` Christophe JAILLET
2022-06-09 7:32 ` Simon Horman
2022-02-11 8:12 ` [PATCH v2 1/2] nfp: flower: Fix a potential leak in nfp_tunnel_add_shared_mac() Simon Horman
2022-02-12 0:53 ` Jakub Kicinski
2022-02-17 7:59 ` Simon Horman
2022-02-17 18:20 ` Christophe JAILLET [this message]
2022-02-18 11:06 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01035905-61f5-da02-36d5-92831e1da184@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=john.hurley@netronome.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).