From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=eFfD=QV=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 3FA94C43381
	for <netdev@archiver.kernel.org>; Thu, 14 Feb 2019 18:19:59 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 13C63222DA
	for <netdev@archiver.kernel.org>; Thu, 14 Feb 2019 18:19:59 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2406651AbfBNST5 (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Thu, 14 Feb 2019 13:19:57 -0500
Received: from linode.aoot.com ([69.164.194.13]:39418 "EHLO linode.aoot.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S2404761AbfBNST5 (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 14 Feb 2019 13:19:57 -0500
X-Greylist: delayed 1541 seconds by postgrey-1.27 at vger.kernel.org; Thu, 14 Feb 2019 13:19:57 EST
Received: from stevoacer (47-221-137-213.gtwncmta03.res.dyn.suddenlink.net [47.221.137.213])
        by linode.aoot.com (Postfix) with ESMTP id 4F04E8285;
        Thu, 14 Feb 2019 11:54:16 -0600 (CST)
From:   "Steve Wise" <swise@opengridcomputing.com>
To:     "'Raju Rangoju'" <rajur@chelsio.com>,
        "'Jason Gunthorpe'" <jgg@mellanox.com>
Cc:     <davem@davemloft.net>, <linux-rdma@vger.kernel.org>,
        <netdev@vger.kernel.org>
References: <20190214121054.11693-1-rajur@chelsio.com> <20190214121054.11693-3-rajur@chelsio.com> <20190214154127.GD1725@mellanox.com> <20190214172801.GA12408@chelsio.com>
In-Reply-To: <20190214172801.GA12408@chelsio.com>
Subject: RE: [rdma-rc PATCH 2/2] iw_cxgb4: cq/qp mask depends on bar2 pages in a host page
Date:   Thu, 14 Feb 2019 11:54:16 -0600
Message-ID: <019501d4c48e$4de3ec90$e9abc5b0$@opengridcomputing.com>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQJoGVCQzdlN+qz9UObNVM9wzACK2AEAmlPeARNRdfECV7DXYqSVjI0w
Content-Language: en-us
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org



> -----Original Message-----
> From: linux-rdma-owner@vger.kernel.org <linux-rdma-
> owner@vger.kernel.org> On Behalf Of Raju Rangoju
> Sent: Thursday, February 14, 2019 11:28 AM
> To: Jason Gunthorpe <jgg@mellanox.com>
> Cc: davem@davemloft.net; linux-rdma@vger.kernel.org;
> netdev@vger.kernel.org; swise@opengridcomputing.com
> Subject: Re: [rdma-rc PATCH 2/2] iw_cxgb4: cq/qp mask depends on bar2
> pages in a host page
> 
> On Thursday, February 02/14/19, 2019 at 15:41:34 +0000, Jason Gunthorpe
> wrote:
> > On Thu, Feb 14, 2019 at 05:40:54PM +0530, Raju Rangoju wrote:
> > > Adjust the cq/qp mask based on no.of bar2 pages in a host page.
> > >
> > > For user-mode rdma, the granularity of the BAR2 memory mapped
> > > to a user rdma process during queue allocation must be based
> > > on the host page size. The lld attributes udb_density and
> > > ucq_density are used to figure out how many sge contexts are
> > > in a bar2 page. So the rdev->qpmask and rdev->cqmask in
> > > iw_cxgb4 need to now be adjusted based on how many sge bar2
> > > pages are in a host page.
> >
> > Why is this rc? Do certain arches fail to work or something?
> >
> 
> Yes, this series fixes a regression that was introduced by commit
> 2391b0030e (v5.0-rc1~129^2~272)
> 
> > Jason

Rdma over cxgb4 on arches with a non-4K page size are busted w/o this fix.
That was the motivation for -rc.