From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: Davide Caratti <dcaratti@redhat.com>
Cc: mptcp@lists.01.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] selftests: mptcp: fix typo in mptcp_connect usage
Date: Wed, 2 Sep 2020 15:32:30 +0200 [thread overview]
Message-ID: <022366c7-c916-8841-348b-b1981341b810@tessares.net> (raw)
In-Reply-To: <6c43e5404c41f91ed9324e20c35a4e4fdb0ed1de.1599046871.git.dcaratti@redhat.com>
Hi Davide,
On 02/09/2020 13:44, Davide Caratti wrote:
> in mptcp_connect, 's' selects IPPROTO_MPTCP / IPPROTO_TCP as the value of
> 'protocol' in socket(), and 'm' switches between different send / receive
> modes. Fix die_usage(): swap 'm' and 's' and add missing 'sendfile' mode.
Good catch!
I guess we don't need this on -net or further, this test program is
always used with its wrapper mptcp_connect.sh.
Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
next prev parent reply other threads:[~2020-09-02 13:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 11:44 [PATCH net-next] selftests: mptcp: fix typo in mptcp_connect usage Davide Caratti
2020-09-02 13:32 ` Matthieu Baerts [this message]
2020-09-02 21:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=022366c7-c916-8841-348b-b1981341b810@tessares.net \
--to=matthieu.baerts@tessares.net \
--cc=dcaratti@redhat.com \
--cc=mptcp@lists.01.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).