netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "shenjian (K)" <shenjian15@huawei.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	<andrew@lunn.ch>, <f.fainelli@gmail.com>, <hkallweit1@gmail.com>,
	<davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <forest.zhouchang@huawei.com>,
	<linuxarm@huawei.com>
Subject: Re: [RFC PATCH net-next] net: phy: force phy suspend when calling phy_stop
Date: Tue, 27 Aug 2019 19:36:50 +0800	[thread overview]
Message-ID: <02aea077-a7b9-0427-5ea4-4914091d7b77@huawei.com> (raw)
In-Reply-To: <cc52cde5-b114-3bf8-4c4b-fe81c04080ee@cogentembedded.com>



在 2019/8/27 18:11, Sergei Shtylyov 写道:
> On 27.08.2019 5:47, Jian Shen wrote:
> 
>> Some ethernet drivers may call phy_start() and phy_stop() from
>> ndo_open and ndo_close() respectively.
> 
>    ndo_open() for consistency.
> 
>> When network cable is unconnected, and operate like below:
>> step 1: ifconfig ethX up -> ndo_open -> phy_start ->start
>> autoneg, and phy is no link.
>> step 2: ifconfig ethX down -> ndo_close -> phy_stop -> just stop
>> phy state machine.
>> step 3: plugin the network cable, and autoneg complete, then
>> LED for link status will be on.
>> step 4: ethtool ethX --> see the result of "Link detected" is no.
>>
>> This patch forces phy suspend even phydev->link is off.
>>
>> Signed-off-by: Jian Shen <shenjian15@huawei.com>
> [...]
> 
> MBR, Sergei
> 
> 
Thanks, will fix it.


      reply	other threads:[~2019-08-27 11:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-27  2:47 [RFC PATCH net-next] net: phy: force phy suspend when calling phy_stop Jian Shen
2019-08-27  5:51 ` Heiner Kallweit
2019-08-27  8:29   ` shenjian (K)
2019-08-27 19:41     ` Heiner Kallweit
2019-08-28  1:03       ` shenjian (K)
2019-08-27 10:11 ` Sergei Shtylyov
2019-08-27 11:36   ` shenjian (K) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02aea077-a7b9-0427-5ea4-4914091d7b77@huawei.com \
    --to=shenjian15@huawei.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=forest.zhouchang@huawei.com \
    --cc=hkallweit1@gmail.com \
    --cc=linuxarm@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).