netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Arınç ÜNAL" <arinc.unal@arinc9.com>
To: DENG Qingfang <dqfext@gmail.com>
Cc: "Luiz Angelo Daros de Luca" <luizluca@gmail.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"John Crispin" <john@phrozen.org>,
	"Siddhant Gupta" <siddhantgupta416@gmail.com>,
	"Ilya Lipnitskiy" <ilya.lipnitskiy@gmail.com>,
	"Sergio Paracuellos" <sergio.paracuellos@gmail.com>,
	"Felix Fietkau" <nbd@nbd.name>,
	"Sean Wang" <sean.wang@mediatek.com>,
	"Mark Lee" <Mark-MC.Lee@mediatek.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"David Miller" <davem@davemloft.net>,
	"René van Dorst" <opensource@vdorst.com>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>,
	netdev <netdev@vger.kernel.org>,
	linux-mips@vger.kernel.org,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	openwrt-devel@lists.openwrt.org, erkin.bozoglu@xeront.com
Subject: Re: MT7621 SoC Traffic Won't Flow on RGMII2 Bus/2nd GMAC
Date: Sun, 23 Jan 2022 11:33:04 +0300	[thread overview]
Message-ID: <02ecce91-7aad-4392-c9d7-f45ca1b31e0b@arinc9.com> (raw)
In-Reply-To: <CALW65jZ4N_YRJd8F-uaETWm1Hs3rNcy95csf++rz7vTk8G8oOg@mail.gmail.com>

Hey Deng,

On 23/01/2022 09:51, DENG Qingfang wrote:
> Hi,
> 
> Do you set the ethernet pinmux correctly?
> 
> &ethernet {
>      pinctrl-names = "default";
>      pinctrl-0 = <&rgmii1_pins &rgmii2_pins &mdio_pins>;
> };

This fixed it! We did have &rgmii2_pins on the gmac1 node (it was 
originally on external_phy) so we never thought to investigate the 
pinctrl configuration further! Turns out &rgmii2_pins needs to be 
defined on the ethernet node instead.

I'll send a patch to address this on mt7621.dtsi.

You saved us a bunch of time, thank you very much!

Cheers.
Arınç

  reply	other threads:[~2022-01-23  8:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-22 18:01 Arınç ÜNAL
2022-01-23  6:51 ` DENG Qingfang
2022-01-23  8:33   ` Arınç ÜNAL [this message]
2022-01-23 15:26     ` Andrew Lunn
2022-01-23 17:48       ` Arınç ÜNAL
2022-01-24 17:13       ` Florian Fainelli
2022-01-24 17:26         ` Russell King (Oracle)
2022-01-24 17:34           ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02ecce91-7aad-4392-c9d7-f45ca1b31e0b@arinc9.com \
    --to=arinc.unal@arinc9.com \
    --cc=Mark-MC.Lee@mediatek.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dqfext@gmail.com \
    --cc=erkin.bozoglu@xeront.com \
    --cc=ilya.lipnitskiy@gmail.com \
    --cc=john@phrozen.org \
    --cc=kuba@kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=luizluca@gmail.com \
    --cc=matthias.bgg@gmail.com \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    --cc=opensource@vdorst.com \
    --cc=openwrt-devel@lists.openwrt.org \
    --cc=sean.wang@mediatek.com \
    --cc=sergio.paracuellos@gmail.com \
    --cc=siddhantgupta416@gmail.com \
    --subject='Re: MT7621 SoC Traffic Won'\''t Flow on RGMII2 Bus/2nd GMAC' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).