From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D894C5517A for ; Mon, 9 Nov 2020 17:13:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2060A20789 for ; Mon, 9 Nov 2020 17:13:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="LZr0ZtB1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730914AbgKIRM5 (ORCPT ); Mon, 9 Nov 2020 12:12:57 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:45542 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730827AbgKIRM5 (ORCPT ); Mon, 9 Nov 2020 12:12:57 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0A9H9lae094874; Mon, 9 Nov 2020 17:12:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=corp-2020-01-29; bh=Qc+P9y4MTm+sba8WvcoApWAUyL3kkxAVQU9oCPyMNko=; b=LZr0ZtB1vri5fCp2idUJT36X/ETjII+bkn3tpxLpml8Am0/AJ3y4LhKMgKx9vrlud6iC okVzKrNqI4DlJ6Nk7f7PSWPo4yHU+zmHqg88u3yNJGeyaEVI/fMccn6X1piyY5GepyWz sacpEuMO7juQDOgr/TwMLJbbXRMeMuAERzrSM73D6cgYm4kK7tsh8tBeeZGAQ/SZwpTG aeE0r2w8b2tnD26g+4qLKravwxhk2/rgTUybZzG1UZteP0MvVm4qT6kCzzRFid2yg0w4 RmxpWQ+qspFt1vJ5WISTxkkTSbR+wglHhl2aFiC02L6hcpioxB4re2S1C2BfgF6vP8RU bg== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 34nkhkq4h0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 09 Nov 2020 17:12:53 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0A9HBBZ8161533; Mon, 9 Nov 2020 17:12:53 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 34p55m71p4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 09 Nov 2020 17:12:53 +0000 Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0A9HCqCm026210; Mon, 9 Nov 2020 17:12:52 GMT Received: from anon-dhcp-152.1015granger.net (/68.61.232.219) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 09 Nov 2020 09:12:51 -0800 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: [PATCH RFC] SUNRPC: Use zero-copy to perform socket send operations From: Chuck Lever In-Reply-To: <9ce015245c916b2c90de72440a22f801142f2c6e.camel@hammerspace.com> Date: Mon, 9 Nov 2020 12:12:50 -0500 Cc: Linux NFS Mailing List , "netdev@vger.kernel.org" Content-Transfer-Encoding: quoted-printable Message-Id: <0313136F-6801-434F-8304-72B9EADD389E@oracle.com> References: <160493771006.15633.8524084764848931537.stgit@klimt.1015granger.net> <9ce015245c916b2c90de72440a22f801142f2c6e.camel@hammerspace.com> To: Trond Myklebust X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9800 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0 phishscore=0 mlxlogscore=999 mlxscore=0 malwarescore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011090118 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9800 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 priorityscore=1501 mlxscore=0 suspectscore=0 mlxlogscore=999 lowpriorityscore=0 spamscore=0 malwarescore=0 adultscore=0 clxscore=1015 bulkscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011090118 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > On Nov 9, 2020, at 12:08 PM, Trond Myklebust = wrote: >=20 > On Mon, 2020-11-09 at 11:03 -0500, Chuck Lever wrote: >> Daire Byrne reports a ~50% aggregrate throughput regression on his >> Linux NFS server after commit da1661b93bf4 ("SUNRPC: Teach server to >> use xprt_sock_sendmsg for socket sends"), which replaced >> kernel_send_page() calls in NFSD's socket send path with calls to >> sock_sendmsg() using iov_iter. >>=20 >> Investigation showed that tcp_sendmsg() was not using zero-copy to >> send the xdr_buf's bvec pages, but instead was relying on memcpy. >>=20 >> Set up the socket and each msghdr that bears bvec pages to use the >> zero-copy mechanism in tcp_sendmsg. >>=20 >> Reported-by: Daire Byrne >> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=3D209439 >> Fixes: da1661b93bf4 ("SUNRPC: Teach server to use xprt_sock_sendmsg >> for socket sends") >> Signed-off-by: Chuck Lever >> --- >> net/sunrpc/socklib.c | 5 ++++- >> net/sunrpc/svcsock.c | 1 + >> net/sunrpc/xprtsock.c | 1 + >> 3 files changed, 6 insertions(+), 1 deletion(-) >>=20 >> This patch does not fully resolve the issue. Daire reports high >> softIRQ activity after the patch is applied, and this activity >> seems to prevent full restoration of previous performance. >>=20 >>=20 >> diff --git a/net/sunrpc/socklib.c b/net/sunrpc/socklib.c >> index d52313af82bc..af47596a7bdd 100644 >> --- a/net/sunrpc/socklib.c >> +++ b/net/sunrpc/socklib.c >> @@ -226,9 +226,12 @@ static int xprt_send_pagedata(struct socket >> *sock, struct msghdr *msg, >> if (err < 0) >> return err; >> =20 >> + msg->msg_flags |=3D MSG_ZEROCOPY; >> iov_iter_bvec(&msg->msg_iter, WRITE, xdr->bvec, >> xdr_buf_pagecount(xdr), >> xdr->page_len + xdr->page_base); >> - return xprt_sendmsg(sock, msg, base + xdr->page_base); >> + err =3D xprt_sendmsg(sock, msg, base + xdr->page_base); >> + msg->msg_flags &=3D ~MSG_ZEROCOPY; >> + return err; >> } >> =20 >> /* Common case: >> diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c >> index c2752e2b9ce3..c814b4953b15 100644 >> --- a/net/sunrpc/svcsock.c >> +++ b/net/sunrpc/svcsock.c >> @@ -1176,6 +1176,7 @@ static void svc_tcp_init(struct svc_sock *svsk, >> struct svc_serv *serv) >> svsk->sk_datalen =3D 0; >> memset(&svsk->sk_pages[0], 0, sizeof(svsk- >>> sk_pages)); >> =20 >> + sock_set_flag(sk, SOCK_ZEROCOPY); >> tcp_sk(sk)->nonagle |=3D TCP_NAGLE_OFF; >> =20 >> set_bit(XPT_DATA, &svsk->sk_xprt.xpt_flags); >> diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c >> index 7090bbee0ec5..343c6396b297 100644 >> --- a/net/sunrpc/xprtsock.c >> +++ b/net/sunrpc/xprtsock.c >> @@ -2175,6 +2175,7 @@ static int xs_tcp_finish_connecting(struct >> rpc_xprt *xprt, struct socket *sock) >> =20 >> /* socket options */ >> sock_reset_flag(sk, SOCK_LINGER); >> + sock_set_flag(sk, SOCK_ZEROCOPY); >> tcp_sk(sk)->nonagle |=3D TCP_NAGLE_OFF; >> =20 >> xprt_clear_connected(xprt); >>=20 >>=20 > I'm thinking we are not really allowed to do that here. The pages we > pass in to the RPC layer are not guaranteed to contain stable data > since they include unlocked page cache pages as well as O_DIRECT = pages. I assume you mean the client side only. Those issues aren't a factor on the server. Not setting SOCK_ZEROCOPY here should be enough to prevent the use of zero-copy on the client. However, the client loses the benefits of sending a page at a time. Is there a desire to remedy that somehow? -- Chuck Lever