netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH iproute2] tc: minor cleanup on ingress
@ 2015-05-09 20:59 Daniel Borkmann
  2015-05-11 16:18 ` Stephen Hemminger
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Borkmann @ 2015-05-09 20:59 UTC (permalink / raw)
  To: stephen; +Cc: jhs, netdev, Daniel Borkmann

Fix whitespacing and remove the unnecessary condition.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
---
 tc/q_ingress.c | 23 +++++++++--------------
 1 file changed, 9 insertions(+), 14 deletions(-)

diff --git a/tc/q_ingress.c b/tc/q_ingress.c
index ba58e72..30b24e7 100644
--- a/tc/q_ingress.c
+++ b/tc/q_ingress.c
@@ -34,18 +34,14 @@ static void explain(void)
 
 static int ingress_parse_opt(struct qdisc_util *qu, int argc, char **argv, struct nlmsghdr *n)
 {
-
-	if (argc > 0) {
-		while (argc > 0) {
-
-			if (strcmp(*argv, "handle") == 0) {
-				NEXT_ARG();
-				argc--; argv++;
-			} else {
-				fprintf(stderr, "What is \"%s\"?\n", *argv);
-				explain();
-				return -1;
-			}
+	while (argc > 0) {
+		if (strcmp(*argv, "handle") == 0) {
+			NEXT_ARG();
+			argc--; argv++;
+		} else {
+			fprintf(stderr, "What is \"%s\"?\n", *argv);
+			explain();
+			return -1;
 		}
 	}
 
@@ -55,8 +51,7 @@ static int ingress_parse_opt(struct qdisc_util *qu, int argc, char **argv, struc
 
 static int ingress_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt)
 {
-
-		fprintf(f, "---------------- ");
+	fprintf(f, "---------------- ");
 	return 0;
 }
 
-- 
1.9.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH iproute2] tc: minor cleanup on ingress
  2015-05-09 20:59 [PATCH iproute2] tc: minor cleanup on ingress Daniel Borkmann
@ 2015-05-11 16:18 ` Stephen Hemminger
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2015-05-11 16:18 UTC (permalink / raw)
  To: Daniel Borkmann; +Cc: jhs, netdev

On Sat,  9 May 2015 22:59:17 +0200
Daniel Borkmann <daniel@iogearbox.net> wrote:

> Fix whitespacing and remove the unnecessary condition.
> 
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

Applied thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-05-11 16:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-09 20:59 [PATCH iproute2] tc: minor cleanup on ingress Daniel Borkmann
2015-05-11 16:18 ` Stephen Hemminger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).