From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30F6AC06510 for ; Tue, 2 Jul 2019 16:31:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E91372082F for ; Tue, 2 Jul 2019 16:31:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="On4AOmeC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726861AbfGBQbD (ORCPT ); Tue, 2 Jul 2019 12:31:03 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:46175 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726401AbfGBQbC (ORCPT ); Tue, 2 Jul 2019 12:31:02 -0400 Received: by mail-pf1-f195.google.com with SMTP id 81so8498039pfy.13 for ; Tue, 02 Jul 2019 09:31:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=TnwPkG+iTbaNgT4SwBC0FtajjMVheShHJgOEezj21l4=; b=On4AOmeCHVKUQR3RFwyiJu3Dt6U0R+7widM/Lzt2YG5CErejQg25Z8v0ikzXO+UekZ 9RHoQ4x0s/6xOFZ3QYEPHti78aHl3VRmBHCW4fRbtZz5OTPpShq/6hmnOd2HxLrkZ7Ns D8/OELrjpbDZ21sZSAtKx5XB4GCt1jQFKllfc1eJ0uj+kBoTseOy9mTdEA+0YvVqpKij EQi9IBlom8WwHfKECGAA8fFvoU+YF8enq/xOyTsVWbIdCFjTR9S3LX+3EV8IT6oeDeI7 q+bGJmIZQLcOHCiGdKynrX9Sczud6tATrzmuHsXqI706hrAECwQBrTgmWvzRM0qyCu9w Cwog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=TnwPkG+iTbaNgT4SwBC0FtajjMVheShHJgOEezj21l4=; b=MmbbiSDxUFyTtYcUKK8NoqViq5tOmxByYnW5Ubz8pBFQV5frZCKE9W+xQlxDLNWbvk IiIFyjMUSgWevIY7QIlJWNfiZTJvWs67bZniL77II/gBwAOg4IXv9DLcRYp2wk6zF6s1 WYV+vVugLIMg9xHOAEsIaRqjmh4/LQoSrCkm9Glu1CWUcIzmdGDJfAiVb+vvSxeIasro SEcuaTy/kI2SuJ2M80TTmiAV9Pe+f9lC5LlXqeWLyjiY42yDN4Bw0/Fe+n8otwuSXpN0 nx1Zn0MMhrzkZ6uZOymYRWUzaOSOqGVdTyDyB6YtggxP/KoF5Yd+MXbM1aZNbUS9ZubZ p2Pg== X-Gm-Message-State: APjAAAUcSwghlTKSRVvtXrRfV6PrxS+N/eK2j9F14CVId7CP4xv/zu2K JtPvW77ypO0If4VaCw6HV1pQfgkVq9w= X-Google-Smtp-Source: APXvYqxlVD3BcyKqW4M82y58fdUg5ZcrZW3FMCuNXgVgT2Hn9wRVGt1d3YbHFcMv3IThnTFqEnwPkg== X-Received: by 2002:a17:90a:b883:: with SMTP id o3mr6569925pjr.50.1562085062197; Tue, 02 Jul 2019 09:31:02 -0700 (PDT) Received: from [172.20.54.151] ([2620:10d:c090:200::ef17]) by smtp.gmail.com with ESMTPSA id x14sm17210214pfq.158.2019.07.02.09.31.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Jul 2019 09:31:01 -0700 (PDT) From: "Jonathan Lemon" To: "Maxim Mikityanskiy" Cc: netdev@vger.kernel.org, bjorn.topel@intel.com, magnus.karlsson@intel.com, jakub.kicinski@netronome.com, jeffrey.t.kirsher@intel.com, kernel-team@fb.com Subject: Re: [PATCH 2/3 bpf-next] i40e: Support zero-copy XDP_TX on the RX path for AF_XDP sockets. Date: Tue, 02 Jul 2019 09:31:00 -0700 X-Mailer: MailMate (1.12.5r5635) Message-ID: <042416A5-BA37-4F07-BD59-7FA13813B8A7@gmail.com> In-Reply-To: References: <20190628221555.3009654-1-jonathan.lemon@gmail.com> <20190628221555.3009654-3-jonathan.lemon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2 Jul 2019, at 0:07, Maxim Mikityanskiy wrote: > On 2019-06-29 01:15, Jonathan Lemon wrote: >> + xdpf = convert_to_xdp_frame_keep_zc(xdp); >> + if (unlikely(!xdpf)) >> + return I40E_XDP_CONSUMED; >> + xdpf->handle = xdp->handle; > > Shouldn't this line belong to convert_to_xdp_frame_keep_zc (and the > previous patch)? It looks like it's code common for all drivers, and > also patch 1 adds the handle field, but doesn't use it, which looks weird. Good point. I'll move it into the function. -- Jonathan