netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Björn Töpel" <bjorn.topel@intel.com>
To: Jakub Kicinski <kuba@kernel.org>,
	Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, nhorman@redhat.com,
	sassmann@redhat.com, jeffrey.t.kirsher@intel.com,
	Andrew Bowers <andrewx.bowers@intel.com>
Subject: Re: [net-next 5/6] i40e, xsk: increase budget for AF_XDP path
Date: Wed, 29 Jul 2020 12:43:46 +0200	[thread overview]
Message-ID: <0439597f-9c1f-a289-edd9-c890baa687da@intel.com> (raw)
In-Reply-To: <20200728131512.17c41621@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

On 2020-07-28 22:15, Jakub Kicinski wrote:
> On Tue, 28 Jul 2020 12:08:41 -0700 Tony Nguyen wrote:
>> diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
>> index 1f2dd591dbf1..99f4afdc403d 100644
>> --- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
>> +++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
>> @@ -265,6 +265,8 @@ static void i40e_inc_ntc(struct i40e_ring *rx_ring)
>>   	rx_ring->next_to_clean = ntc;
>>   }
>>   
>> +#define I40E_XSK_CLEAN_RX_BUDGET 256U
>> +
>>   /**
>>    * i40e_clean_rx_irq_zc - Consumes Rx packets from the hardware ring
>>    * @rx_ring: Rx ring
>> @@ -280,7 +282,7 @@ int i40e_clean_rx_irq_zc(struct i40e_ring *rx_ring, int budget)
>>   	bool failure = false;
>>   	struct sk_buff *skb;
>>   
>> -	while (likely(total_rx_packets < (unsigned int)budget)) {
>> +	while (likely(total_rx_packets < I40E_XSK_CLEAN_RX_BUDGET)) {
>>   		union i40e_rx_desc *rx_desc;
>>   		struct xdp_buff **bi;
>>   		unsigned int size;
> 
> Should this perhaps be a common things that drivers do?
> 
> Should we define a "XSK_NAPI_WEIGHT_MULT 4" instead of hard coding the
> value in a driver?
>

Yes, that's a good idea. I can generalize for the AF_XDP paths in the 
other drivers as a follow up!


Cheers,
Björn (in vacation mode)

  reply	other threads:[~2020-07-29 10:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-28 19:08 [net-next 0/6][pull request] 40GbE Intel Wired LAN Driver Updates 2020-07-28 Tony Nguyen
2020-07-28 19:08 ` [net-next 1/6] i40e: not compute affinity_mask for IRQ Tony Nguyen
2020-07-28 19:08 ` [net-next 2/6] i40e: prefetch struct page of Rx buffer conditionally Tony Nguyen
2020-07-28 20:14   ` Jakub Kicinski
2020-07-29  6:20     ` 答复: " Li,Rongqing
2020-07-29 21:20       ` Jakub Kicinski
2020-07-30  1:15         ` 答复: " Li,Rongqing
2020-07-28 19:08 ` [net-next 3/6] i40e, xsk: remove HW descriptor prefetch in AF_XDP path Tony Nguyen
2020-07-28 19:08 ` [net-next 4/6] i40e: use 16B HW descriptors instead of 32B Tony Nguyen
2020-07-28 19:08 ` [net-next 5/6] i40e, xsk: increase budget for AF_XDP path Tony Nguyen
2020-07-28 20:15   ` Jakub Kicinski
2020-07-29 10:43     ` Björn Töpel [this message]
2020-07-29 21:22       ` Jakub Kicinski
2020-07-28 19:08 ` [net-next 6/6] i40e, xsk: move buffer allocation out of the Rx processing loop Tony Nguyen
2020-07-28 20:16 ` [net-next 0/6][pull request] 40GbE Intel Wired LAN Driver Updates 2020-07-28 Jakub Kicinski
2020-08-10 11:47   ` Björn Töpel
2020-08-10 11:51     ` Björn Töpel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0439597f-9c1f-a289-edd9-c890baa687da@intel.com \
    --to=bjorn.topel@intel.com \
    --cc=andrewx.bowers@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@redhat.com \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).