From: Daniel Borkmann <daniel@iogearbox.net>
To: "NOMURA JUNICHI(野村 淳一)" <junichi.nomura@nec.com>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "ast@kernel.org" <ast@kernel.org>,
"toke@redhat.com" <toke@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf] devmap: Use GFP_KERNEL for xdp bulk queue allocation
Date: Sat, 13 Feb 2021 00:17:38 +0100 [thread overview]
Message-ID: <0692ede4-1f1e-2a19-db02-024c47f93202@iogearbox.net> (raw)
In-Reply-To: <20210209082451.GA44021@jeru.linux.bs1.fc.nec.co.jp>
On 2/9/21 9:24 AM, NOMURA JUNICHI(野村 淳一) wrote:
> The devmap bulk queue is allocated with GFP_ATOMIC and the allocation may
> fail if there is no available space in existing percpu pool.
>
> Since commit 75ccae62cb8d42 ("xdp: Move devmap bulk queue into struct net_device")
> moved the bulk queue allocation to NETDEV_REGISTER callback, whose context
> is allowed to sleep, use GFP_KERNEL instead of GFP_ATOMIC to let percpu
> allocator extend the pool when needed and avoid possible failure of netdev
> registration.
>
> As the required alignment is natural, we can simply use alloc_percpu().
>
> Signed-off-by: Jun'ichi Nomura <junichi.nomura@nec.com>
Applied, thanks!
prev parent reply other threads:[~2021-02-12 23:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 8:24 [PATCH bpf] devmap: Use GFP_KERNEL for xdp bulk queue allocation NOMURA JUNICHI(野村 淳一)
2021-02-12 23:17 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0692ede4-1f1e-2a19-db02-024c47f93202@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=junichi.nomura@nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).