From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6B2FCA9EB7 for ; Mon, 21 Oct 2019 14:01:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD6702084C for ; Mon, 21 Oct 2019 14:01:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=candelatech.com header.i=@candelatech.com header.b="dB9W91qh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729167AbfJUOBE (ORCPT ); Mon, 21 Oct 2019 10:01:04 -0400 Received: from mail2.candelatech.com ([208.74.158.173]:51700 "EHLO mail3.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727152AbfJUOBE (ORCPT ); Mon, 21 Oct 2019 10:01:04 -0400 Received: from [192.168.1.47] (unknown [50.34.216.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail3.candelatech.com (Postfix) with ESMTPSA id A377D137563; Mon, 21 Oct 2019 07:01:01 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 mail3.candelatech.com A377D137563 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=candelatech.com; s=default; t=1571666463; bh=TC0IC7ijVgH9EVtRApZTiGeFe1tzHYJg6SGZj3JD57E=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From; b=dB9W91qhjuh+ZefuIByWJyo92qyfGQjN7Ueu0zjVFermwckAaik1XLfzrxBbMV14O Y8rhWNATIjDSg9KiPv1imIYSGJKhO2yb5M/ZN1AQ+TD/HMkfWGbVDbUqi/AzoJeolO c15E661Rx/PoWdnGtBrkm/EoSyvy755xltPfPqG8= Subject: Re: WARNING at net/mac80211/sta_info.c:1057 (__sta_info_destroy_part2()) To: =?UTF-8?Q?Tomislav_Po=c5=beega?= , kvalo@codeaurora.org References: <87lfuuln5n.fsf@tynnyri.adurom.net> <1571584320-29816-1-git-send-email-pozega.tomislav@gmail.com> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, davem@davemloft.net, torvalds@linux-foundation.org, johannes@sipsolutions.net, linux-wireless@vger.kernel.org From: Ben Greear Message-ID: <073b0ffb-187b-659e-0967-23ae44c5c660@candelatech.com> Date: Mon, 21 Oct 2019 07:01:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1571584320-29816-1-git-send-email-pozega.tomislav@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 10/20/2019 08:12 AM, Tomislav Požega wrote: >> -11 is -EAGAIN which would mean that the HTC credits have run out some >> reason for the WMI command: >> >> if (ep->tx_credits < credits) { >> ath10k_dbg(ar, ATH10K_DBG_HTC, >> "htc insufficient credits ep %d required %d available %d\n", >> eid, credits, ep->tx_credits); >> spin_unlock_bh(&htc->tx_lock); >> ret = -EAGAIN; >> goto err_pull; >> } >> >> Credits can run out, for example, if there's a lot of WMI command/event >> activity and are not returned during the 3s wait, firmware crashed or >> problems with the PCI bus. > > Hi > > Can this occur if the target memory is not properly allocated? I have only seen this on wave-1 cards, and it is usually paired with situations where the wave-1 stops doing WMI related interrupts properly as best as I can understand. If I force the firmware to poll instead of waiting for irqs, then WMI communication will work for a while...I have not implemented that on the driver side though, so I still see these WMI timeout issues. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com