From: Randy Dunlap <rdunlap@infradead.org>
To: Eli Cohen <elic@nvidia.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: Leon Romanovsky <leonro@nvidia.com>,
virtualization@lists.linux-foundation.org,
LKML <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jason Wang <jasowang@redhat.com>,
Saeed Mahameed <saeedm@nvidia.com>
Subject: Re: [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors
Date: Thu, 24 Sep 2020 08:47:05 -0700 [thread overview]
Message-ID: <079c831e-214d-22c1-028e-05d84e3b7f04@infradead.org> (raw)
In-Reply-To: <20200924102413.GD170403@mtl-vdi-166.wap.labs.mlnx>
On 9/24/20 3:24 AM, Eli Cohen wrote:
> On Thu, Sep 24, 2020 at 05:30:55AM -0400, Michael S. Tsirkin wrote:
>>>> --- linux-next-20200917.orig/drivers/vdpa/Kconfig
>>>> +++ linux-next-20200917/drivers/vdpa/Kconfig
>>>> @@ -31,7 +31,7 @@ config IFCVF
>>>>
>>>> config MLX5_VDPA
>>>> bool "MLX5 VDPA support library for ConnectX devices"
>>>> - depends on MLX5_CORE
>>>> + depends on VHOST_IOTLB && MLX5_CORE
>>>> default n
>>>
>>> While we are here, can anyone who apply this patch delete the "default n" line?
>>> It is by default "n".
>
> I can do that
>
>>>
>>> Thanks
>>
>> Hmm other drivers select VHOST_IOTLB, why not do the same?
v1 used select, but Saeed requested use of depends instead because
select can cause problems.
> I can't see another driver doing that. Perhaps I can set dependency on
> VHOST which by itself depends on VHOST_IOTLB?
>>
>>
>>>> help
>>>> Support library for Mellanox VDPA drivers. Provides code that is
>>>>
>>
--
~Randy
next prev parent reply other threads:[~2020-09-24 15:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 2:35 [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors Randy Dunlap
2020-09-18 8:22 ` Leon Romanovsky
2020-09-24 9:30 ` Michael S. Tsirkin
2020-09-24 10:24 ` Eli Cohen
2020-09-24 15:47 ` Randy Dunlap [this message]
2020-09-24 16:02 ` Michael S. Tsirkin
2020-09-25 7:20 ` Leon Romanovsky
2020-09-25 10:19 ` Michael S. Tsirkin
2020-09-25 11:29 ` Jason Wang
2020-09-26 6:53 ` Leon Romanovsky
2020-09-29 7:47 ` Michael S. Tsirkin
2020-09-25 10:20 ` Michael S. Tsirkin
2020-09-29 6:01 ` Eli Cohen
2020-09-29 6:10 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=079c831e-214d-22c1-028e-05d84e3b7f04@infradead.org \
--to=rdunlap@infradead.org \
--cc=elic@nvidia.com \
--cc=jasowang@redhat.com \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).