From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=q6Zc=QS=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id BC2C4C282C2
	for <netdev@archiver.kernel.org>; Mon, 11 Feb 2019 02:36:33 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 937CF2083B
	for <netdev@archiver.kernel.org>; Mon, 11 Feb 2019 02:36:33 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726310AbfBKCgc (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Sun, 10 Feb 2019 21:36:32 -0500
Received: from szxga06-in.huawei.com ([45.249.212.32]:53284 "EHLO huawei.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1726101AbfBKCgc (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sun, 10 Feb 2019 21:36:32 -0500
Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59])
        by Forcepoint Email with ESMTP id 1CA69BA90AEE59403343;
        Mon, 11 Feb 2019 10:36:30 +0800 (CST)
Received: from [127.0.0.1] (10.184.225.177) by DGGEMS413-HUB.china.huawei.com
 (10.3.19.213) with Microsoft SMTP Server id 14.3.408.0; Mon, 11 Feb 2019
 10:36:22 +0800
Subject: Re: [PATCH] net: fix IPv6 prefix route residue
To:     David Ahern <dsahern@gmail.com>, David Miller <davem@redhat.com>
CC:     <thaller@redhat.com>, <yoshfuji@linux-ipv6.org>,
        <0xeffeff@gmail.com>, <edumazet@google.com>,
        <netdev@vger.kernel.org>, <mingfangsen@huawei.com>,
        <zhangwenhao8@huawei.com>, <wangxiaogang3@huawei.com>,
        <zhoukang7@huawei.com>, <kuznet@ms2.inr.ac.ru>
References: <98d563a5-34f0-a504-d62f-d20ed7c770da@huawei.com>
 <20190203.090411.1685970814345088903.davem@redhat.com>
 <a0b5e6cd-ea0f-771b-c131-466ec6210507@gmail.com>
From:   Zhiqiang Liu <liuzhiqiang26@huawei.com>
Message-ID: <07a38a20-63d8-a45f-6975-d799d7248f7e@huawei.com>
Date:   Mon, 11 Feb 2019 10:36:06 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.0
MIME-Version: 1.0
In-Reply-To: <a0b5e6cd-ea0f-771b-c131-466ec6210507@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.184.225.177]
X-CFilter-Loop: Reflected
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

> On 2/3/19 9:04 AM, David Miller wrote:
>> From: Zhiqiang Liu <liuzhiqiang26@huawei.com>
>> Date: Sun, 3 Feb 2019 14:10:31 +0800
>>
>>> @@ -1165,7 +1165,8 @@ enum cleanup_prefix_rt_t {
>>>  	list_for_each_entry(ifa, &idev->addr_list, if_list) {
>>>  		if (ifa == ifp)
>>>  			continue;
>>> -		if (!ipv6_prefix_equal(&ifa->addr, &ifp->addr,
>>> +		if (ifa->prefix_len != ifp->prefix_len ||
>>> +			!ipv6_prefix_equal(&ifa->addr, &ifp->addr,
>>>  				       ifp->prefix_len))
>>
>> Please fix the indentation of this conditional, it should be:
>>
>> 		if (ifa->prefix_len != ifp->prefix_len ||
>> 		    !ipv6_prefix_equal(&ifa->addr, &ifp->addr,
>> 				       ifp->prefix_len))
>>
>> Thank you.
Thank you for your suggestion. I have fixed the indentation of the
conditional. In addition, I have used the checkpatch.pl script to check the
patch.
>>
> 
> Needs a Fixes tag too.
> 
> Fixes: 5b84efecb7d9 ("ipv6 addrconf: don't cleanup prefix route for
> IFA_F_NOPREFIXROUTE")
> 
> and cc to that author Thomas Haller <thaller@redhat.com>
> 
> .
> 
Thank you. The Fixes tag is added in the v2 patch.