From: Hayes Wang <hayeswang-Rasf1IRRPZFBDgjK7y7TUQ@public.gmane.org>
To: Oliver Neukum <oneukum-IBi9RG/b67k@public.gmane.org>
Cc: "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
nic_swsd <nic_swsd-Rasf1IRRPZFBDgjK7y7TUQ@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: RE: [PATCH net 2/3] r8152: fix remote wakeup
Date: Thu, 23 Jul 2015 09:55:41 +0000 [thread overview]
Message-ID: <0835B3720019904CB8F7AA43166CEEB2F3AC58@RTITMBSV03.realtek.com.tw> (raw)
In-Reply-To: <1437640258.4377.6.camel-IBi9RG/b67k@public.gmane.org>
> Hi,
>
> this is most likely wrong. Usbcore does check for a device's ability to
> do remote wakeup and will block a runtime suspend if it detects that
> a remote wakeup would be required but the device cannot deliver.
> (static int autosuspend_check())
>
> So by removing the flag in the probe() method means that devices will
> suspend during operations without remote wakeup requested. Thus an
> incoming packet cannot wake them up.
>
> If you remove setting the flag on probe() you need to set it at open()
> [and reset on close()], as devices which cannot do remote wakeup must
> only be suspended when they are down.
Hi,
I don't think I understand your description clearly. My idea is that if the
device doesn't support wakeup, we don't need set " needs_remote_wakeup".
We allow the device could be suspended and couldn't be waked up by
incoming packet. The system could be waked up by other methods except
by the device.
I don't understand why I have to set it at open() and reset it at close(). And
why must the device only be suspended when it is down?
Best Regards,
Hayes
next prev parent reply other threads:[~2015-07-23 9:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 7:09 [PATCH net 0/3] r8152: issues fix Hayes Wang
2015-07-23 7:09 ` [PATCH net 1/3] r8152: fix the issue about U1/U2 Hayes Wang
2015-07-23 7:09 ` [PATCH net 2/3] r8152: fix remote wakeup Hayes Wang
[not found] ` <1394712342-15778-150-Taiwan-albertk-Rasf1IRRPZFBDgjK7y7TUQ@public.gmane.org>
2015-07-23 8:30 ` Oliver Neukum
[not found] ` <1437640258.4377.6.camel-IBi9RG/b67k@public.gmane.org>
2015-07-23 9:55 ` Hayes Wang [this message]
2015-07-23 10:27 ` Oliver Neukum
[not found] ` <1437647246.4377.33.camel-IBi9RG/b67k@public.gmane.org>
2015-07-23 11:30 ` Hayes Wang
2015-07-23 7:09 ` [PATCH net 3/3] r8152: don't enable napi before rx ready Hayes Wang
2015-07-24 5:54 ` [PATCH net v2 0/3] r8152: issues fix Hayes Wang
2015-07-24 5:54 ` [PATCH net v2 1/3] r8152: fix the issue about U1/U2 Hayes Wang
2015-07-24 5:54 ` [PATCH net v2 2/3] r8152: fix wakeup settings Hayes Wang
2015-07-24 5:54 ` [PATCH net v2 3/3] r8152: don't enable napi before rx ready Hayes Wang
2015-07-27 7:56 ` [PATCH net v2 0/3] r8152: issues fix David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0835B3720019904CB8F7AA43166CEEB2F3AC58@RTITMBSV03.realtek.com.tw \
--to=hayeswang-rasf1irrpzfbdgjk7y7tuq@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nic_swsd-Rasf1IRRPZFBDgjK7y7TUQ@public.gmane.org \
--cc=oneukum-IBi9RG/b67k@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).