* [PATCH] appletalk: Fix atalk_proc_init() return path
@ 2020-08-02 5:06 Lukas Wunner
2020-08-03 22:49 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Wunner @ 2020-08-02 5:06 UTC (permalink / raw)
To: David Miller, Jakub Kicinski
Cc: Vincent Duvert, Christopher KOBAYASHI, Doug Brown, Yue Haibing, netdev
From: Vincent Duvert <vincent.ldev@duvert.net>
Add a missing return statement to atalk_proc_init so it doesn't return
-ENOMEM when successful. This allows the appletalk module to load
properly.
Fixes: e2bcd8b0ce6e ("appletalk: use remove_proc_subtree to simplify procfs code")
Link: https://www.downtowndougbrown.com/2020/08/hacking-up-a-fix-for-the-broken-appletalk-kernel-module-in-linux-5-1-and-newer/
Reported-by: Christopher KOBAYASHI <chris@disavowed.jp>
Reported-by: Doug Brown <doug@downtowndougbrown.com>
Signed-off-by: Vincent Duvert <vincent.ldev@duvert.net>
[lukas: add missing tags]
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Cc: stable@vger.kernel.org # v5.1+
Cc: Yue Haibing <yuehaibing@huawei.com>
---
net/appletalk/atalk_proc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/appletalk/atalk_proc.c b/net/appletalk/atalk_proc.c
index 550c6ca..9c12412 100644
--- a/net/appletalk/atalk_proc.c
+++ b/net/appletalk/atalk_proc.c
@@ -229,6 +229,8 @@ int __init atalk_proc_init(void)
sizeof(struct aarp_iter_state), NULL))
goto out;
+ return 0;
+
out:
remove_proc_subtree("atalk", init_net.proc_net);
return -ENOMEM;
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] appletalk: Fix atalk_proc_init() return path
2020-08-02 5:06 [PATCH] appletalk: Fix atalk_proc_init() return path Lukas Wunner
@ 2020-08-03 22:49 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-08-03 22:49 UTC (permalink / raw)
To: lukas; +Cc: kuba, vincent.ldev, chris, doug, yuehaibing, netdev
From: Lukas Wunner <lukas@wunner.de>
Date: Sun, 2 Aug 2020 07:06:51 +0200
> From: Vincent Duvert <vincent.ldev@duvert.net>
>
> Add a missing return statement to atalk_proc_init so it doesn't return
> -ENOMEM when successful. This allows the appletalk module to load
> properly.
>
> Fixes: e2bcd8b0ce6e ("appletalk: use remove_proc_subtree to simplify procfs code")
> Link: https://www.downtowndougbrown.com/2020/08/hacking-up-a-fix-for-the-broken-appletalk-kernel-module-in-linux-5-1-and-newer/
> Reported-by: Christopher KOBAYASHI <chris@disavowed.jp>
> Reported-by: Doug Brown <doug@downtowndougbrown.com>
> Signed-off-by: Vincent Duvert <vincent.ldev@duvert.net>
> [lukas: add missing tags]
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
Shows how many people are actually using appletalk if it doesn't even
load since v5.1
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-03 22:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-02 5:06 [PATCH] appletalk: Fix atalk_proc_init() return path Lukas Wunner
2020-08-03 22:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).