From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Marek Vasut <marex@denx.de>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] dt-bindings: net: snps,stmmac: Fix inconsistencies in some properties belonging to stmmac-axi-config
Date: Thu, 12 Jan 2023 09:40:50 +0900 [thread overview]
Message-ID: <0a4aab39-7799-d18e-f146-f946776defb3@socionext.com> (raw)
In-Reply-To: <7c0156a5-6520-bb3b-ae84-222ad1d1674b@linaro.org>
Hi Krzysztof,
On 2023/01/11 18:19, Krzysztof Kozlowski wrote:
> On 11/01/2023 03:26, Kunihiko Hayashi wrote:
>> The description of some properties in stmmac-axi-config don't match the
>> behavior of the corresponding driver. Fix the inconsistencies by fixing
>> the dt-schema.
>>
>> Fixes: 5361660af6d3 ("dt-bindings: net: snps,dwmac: Document
>> stmmac-axi-config subnode")
>> Fixes: afea03656add ("stmmac: rework DMA bus setting and introduce new
>> platform AXI structure")
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>
> NAK.
>
> I don't understand what do you mean by "corresponding driver". Driver
> uses existing properties in current next.
Sorry for my mistake.
I found my local repository was out of date and
the commit 61d4f140943c ("net: stmmac: fix "snps,axi-config" node property parsing")
had already solved the issue to fix the driver.
>> ---
>> .../devicetree/bindings/net/snps,dwmac.yaml | 16 ++++++++--------
>> 1 file changed, 8 insertions(+), 8 deletions(-)
>>
>> In this patch the definition of the corresponding driver is applied.
>> If applying the definition of the devicetree, we need to change the driver
>> instead of this patch.
>>
>> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>> b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>> index e88a86623fce..2332bf7cfcd4 100644
>> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>> @@ -158,11 +158,11 @@ properties:
>> * snps,xit_frm, unlock on WoL
>> * snps,wr_osr_lmt, max write outstanding req. limit
>> * snps,rd_osr_lmt, max read outstanding req. limit
>> - * snps,kbbe, do not cross 1KiB boundary.
>> + * snps,axi_kbbe, do not cross 1KiB boundary.
>> * snps,blen, this is a vector of supported burst length.
>> - * snps,fb, fixed-burst
>> - * snps,mb, mixed-burst
>> - * snps,rb, rebuild INCRx Burst
>> + * snps,axi_fb, fixed-burst
>> + * snps,axi_mb, mixed-burst
>> + * snps,axi_rb, rebuild INCRx Burst
>>
>> snps,mtl-rx-config:
>> $ref: /schemas/types.yaml#/definitions/phandle
>> @@ -516,7 +516,7 @@ properties:
>> description:
>> max read outstanding req. limit
>>
>> - snps,kbbe:
>> + snps,axi_kbbe:
>
> There is no such property. Driver parses snps,kbbe. What's more you
> introduce invalid character - underscore - for property name.
I understand the invalid character. This issue should have been fixed
in the driver parsing and was already fixed.
Thank you,
---
Best Regards
Kunihiko Hayashi
prev parent reply other threads:[~2023-01-12 0:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 2:26 [PATCH net] dt-bindings: net: snps,stmmac: Fix inconsistencies in some properties belonging to stmmac-axi-config Kunihiko Hayashi
2023-01-11 9:19 ` Krzysztof Kozlowski
2023-01-12 0:40 ` Kunihiko Hayashi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a4aab39-7799-d18e-f146-f946776defb3@socionext.com \
--to=hayashi.kunihiko@socionext.com \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).