From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A82CC433DB for ; Mon, 18 Jan 2021 17:43:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E78B522CB1 for ; Mon, 18 Jan 2021 17:43:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407249AbhARRmx (ORCPT ); Mon, 18 Jan 2021 12:42:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407243AbhARRmY (ORCPT ); Mon, 18 Jan 2021 12:42:24 -0500 Received: from mail-oo1-xc29.google.com (mail-oo1-xc29.google.com [IPv6:2607:f8b0:4864:20::c29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE367C061575 for ; Mon, 18 Jan 2021 09:41:43 -0800 (PST) Received: by mail-oo1-xc29.google.com with SMTP id v19so4276916ooj.7 for ; Mon, 18 Jan 2021 09:41:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6BjCsUjB+34z59FFJM6pqts8kRnU0zDorKLQzUCDKJs=; b=C9+ZuYyCmFbtUCO/9J1Un432+HswCa6HDrrydoctvIi+eIiRElzqjJ1O7fEj6ejnrX N/XPaiKwNRXuImOY5rF029D6tXwtfQS2YX9GoS6wjNaaaBci1DlkKqMLdn/haGwu/8cz G+YewtlfRrokfpz65TmvV6OxlbGAQiH9iQs5lhyMnRvXlH/+oh22G8NzuxhFVNA6uImF OdGeB/+V8HbPbh9KCbFKEPrl0eC2HHaP/fd+KE69gAR9ZKQdGqW0r0XNuGl+xs93WP4P qiUGR+BBiS5IaJt/DV1fLV56RYQyMco+E2h4WCXoyBRz4SDXbJOPTZMx9dVsSIA6dUy7 SHig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6BjCsUjB+34z59FFJM6pqts8kRnU0zDorKLQzUCDKJs=; b=AAvMESvAhOGFiEgwMasc4qHqF4jtPNb2a/S6gs+PM7Q4uygYyVwuUnLqiOjJ9HV9kF F4TNHm2Udh481q5gqHN26CgjLTMbj+XPlo/Xhhit2zj9Hx9gZa1P/9S8PnoMXnczdm52 otU5iTGyYuUmmD3JNYDUl0k02wNrcFKJuMP2VFGv4Qa3aX2+uIzA606g/yfxA1foQjii Jdcra9Db04ihOS19en1osvaVph8wwkzL1v+E7gfJfgvJV9ZleEprbhzcjjMZnjyAlqES TCWZu4VAN9bnMAelEmsUipaW6bjoB/tXu+WrGEHwRfK9S2MzbGaxQWw7tOs/j4zSdZGp jujg== X-Gm-Message-State: AOAM530zy/4srJptN7bvPbYTIit0plM2upzGJVDOAwkY+5YMQ8a67nIC D0kkJc9U3w6+MyirPbvdRJA= X-Google-Smtp-Source: ABdhPJzZL8leDtUp59MWZ7zEWUVi9nzEuEsDpxq+BdCGlE0gjWp1eaDXTt4Lp7BlXECTtZf2so3ksg== X-Received: by 2002:a05:6820:22c:: with SMTP id j12mr156483oob.65.1610991703310; Mon, 18 Jan 2021 09:41:43 -0800 (PST) Received: from Davids-MacBook-Pro.local ([8.6.112.248]) by smtp.googlemail.com with ESMTPSA id k65sm2018123oia.19.2021.01.18.09.41.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jan 2021 09:41:42 -0800 (PST) Subject: Re: [PATCH net-next 1/3] nexthop: Use a dedicated policy for nh_valid_get_del_req() To: Petr Machata , netdev@vger.kernel.org Cc: David Ahern , "David S. Miller" , Jakub Kicinski , Ido Schimmel References: From: David Ahern Message-ID: <0abdd7bb-e618-e68c-7597-9de475cfb92e@gmail.com> Date: Mon, 18 Jan 2021 10:41:41 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/18/21 7:05 AM, Petr Machata wrote: > This function uses the global nexthop policy only to then bounce all > arguments except for NHA_ID. Instead, just create a new policy that > only includes the one allowed attribute. > > Signed-off-by: Petr Machata > Reviewed-by: Ido Schimmel > --- > net/ipv4/nexthop.c | 21 ++++++--------------- > 1 file changed, 6 insertions(+), 15 deletions(-) > Reviewed-by: David Ahern