From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: Stephen Suryaputra <ssuryaextr@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3] ipv4: Support multipath hashing on inner IP pkts for GRE tunnel
Date: Fri, 14 Jun 2019 13:55:09 +0300 [thread overview]
Message-ID: <0bd371a1-ac51-ebfd-31f9-e897247c4184@cumulusnetworks.com> (raw)
In-Reply-To: <20190613183858.9892-1-ssuryaextr@gmail.com>
On 13/06/2019 21:38, Stephen Suryaputra wrote:
> Multipath hash policy value of 0 isn't distributing since the outer IP
> dest and src aren't varied eventhough the inner ones are. Since the flow
> is on the inner ones in the case of tunneled traffic, hashing on them is
> desired.
>
> This is done mainly for IP over GRE, hence only tested for that. But
> anything else supported by flow dissection should work.
>
> v2: Use skb_flow_dissect_flow_keys() directly so that other tunneling
> can be supported through flow dissection (per Nikolay Aleksandrov).
> v3: Remove accidental inclusion of ports in the hash keys and clarify
> the documentation (Nikolay Alexandrov).
> Signed-off-by: Stephen Suryaputra <ssuryaextr@gmail.com>
> ---
> Documentation/networking/ip-sysctl.txt | 1 +
> net/ipv4/route.c | 17 +++++++++++++++++
> net/ipv4/sysctl_net_ipv4.c | 2 +-
> 3 files changed, 19 insertions(+), 1 deletion(-)
>
Looks good to me,
Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
next prev parent reply other threads:[~2019-06-14 10:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 18:38 [PATCH net-next v3] ipv4: Support multipath hashing on inner IP pkts for GRE tunnel Stephen Suryaputra
2019-06-14 10:55 ` Nikolay Aleksandrov [this message]
2019-06-15 2:43 ` David Miller
2019-06-17 14:39 ` Ido Schimmel
2019-06-17 15:53 ` David Ahern
2019-06-17 17:08 ` Stephen Suryaputra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bd371a1-ac51-ebfd-31f9-e897247c4184@cumulusnetworks.com \
--to=nikolay@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=ssuryaextr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).