From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Toms Atteka <cpp.code.lv@gmail.com>, netdev@vger.kernel.org
Cc: pshelar@ovn.org, davem@davemloft.net, kuba@kernel.org,
dev@openvswitch.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v5] net: openvswitch: IPv6: Add IPv6 extension header support
Date: Thu, 23 Sep 2021 08:02:43 +0200 [thread overview]
Message-ID: <0d70b112-dc7a-7083-db8d-183782b8ef8f@6wind.com> (raw)
In-Reply-To: <20210920182038.1510501-1-cpp.code.lv@gmail.com>
Le 20/09/2021 à 20:20, Toms Atteka a écrit :
> This change adds a new OpenFlow field OFPXMT_OFB_IPV6_EXTHDR and
> packets can be filtered using ipv6_ext flag.
>
> Signed-off-by: Toms Atteka <cpp.code.lv@gmail.com>
> ---
> include/uapi/linux/openvswitch.h | 12 +++
> net/openvswitch/flow.c | 140 +++++++++++++++++++++++++++++++
> net/openvswitch/flow.h | 14 ++++
> net/openvswitch/flow_netlink.c | 24 +++++-
> 4 files changed, 189 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/openvswitch.h
> index a87b44cd5590..dc6eb5f6399f 100644
> --- a/include/uapi/linux/openvswitch.h
> +++ b/include/uapi/linux/openvswitch.h
> @@ -346,6 +346,13 @@ enum ovs_key_attr {
> #ifdef __KERNEL__
> OVS_KEY_ATTR_TUNNEL_INFO, /* struct ip_tunnel_info */
> #endif
> +
> +#ifndef __KERNEL__
> + PADDING, /* Padding so kernel and non kernel field count would match */
> +#endif
> +
> + OVS_KEY_ATTR_IPV6_EXTHDRS, /* struct ovs_key_ipv6_exthdr */
Naive question, why not moving OVS_KEY_ATTR_IPV6_EXTHDRS above
OVS_KEY_ATTR_TUNNEL_INFO?
Regards,
Nicolas
next prev parent reply other threads:[~2021-09-23 6:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 18:20 [PATCH net-next v5] net: openvswitch: IPv6: Add IPv6 extension header support Toms Atteka
2021-09-21 17:15 ` Jakub Kicinski
2021-09-23 6:02 ` Nicolas Dichtel [this message]
2021-09-27 19:12 ` Cpp Code
2021-09-28 14:51 ` Nicolas Dichtel
2021-09-28 19:20 ` Cpp Code
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d70b112-dc7a-7083-db8d-183782b8ef8f@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=cpp.code.lv@gmail.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).