From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Yuusuke Ashizuka <ashiduka@fujitsu.com>
Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v2] ravb: Fixed the problem that rmmod can not be done
Date: Fri, 31 Jul 2020 21:32:32 +0300 [thread overview]
Message-ID: <0e7d72fe-ea70-612c-7a50-ad1ff905ddf4@gmail.com> (raw)
In-Reply-To: <20200730100151.7490-1-ashiduka@fujitsu.com>
On 7/30/20 1:01 PM, Yuusuke Ashizuka wrote:
CCing DaveM (as you should have done from the start)...
> ravb is a module driver, but I cannot rmmod it after insmod it.
> ravb does mdio_init() at the time of probe, and module->refcnt is incremented
> by alloc_mdio_bitbang() called after that.
> Therefore, even if ifup is not performed, the driver is in use and rmmod cannot
> be performed.
>
> $ lsmod
> Module Size Used by
Did you also build mdio-bitbang.c as a module? For the in-kernal driver, not
being able to rmmod the 'ravb' one sounds logical. :-)
> ravb 40960 1
> $ rmmod ravb
> rmmod: ERROR: Module ravb is in use
>
> Fixed to execute mdio_init() at open and free_mdio() at close, thereby rmmod is
Call ravb_mdio_init() at open and free_mdio_bitbang() at close.
> possible in the ifdown state.
Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
> Signed-off-by: Yuusuke Ashizuka <ashiduka@fujitsu.com>
Reviewed-by: Sergei Shtylyov <sergei.shtylyov@gmail.com>
[...]
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> index 99f7aae102ce..df89d09b253e 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -1342,6 +1342,51 @@ static inline int ravb_hook_irq(unsigned int irq, irq_handler_t handler,
> return error;
> }
>
> +/* MDIO bus init function */
> +static int ravb_mdio_init(struct ravb_private *priv)
> +{
> + struct platform_device *pdev = priv->pdev;
> + struct device *dev = &pdev->dev;
> + int error;
> +
> + /* Bitbang init */
> + priv->mdiobb.ops = &bb_ops;
> +
> + /* MII controller setting */
> + priv->mii_bus = alloc_mdio_bitbang(&priv->mdiobb);
> + if (!priv->mii_bus)
> + return -ENOMEM;
> +
> + /* Hook up MII support for ethtool */
> + priv->mii_bus->name = "ravb_mii";
> + priv->mii_bus->parent = dev;
> + snprintf(priv->mii_bus->id, MII_BUS_ID_SIZE, "%s-%x",
> + pdev->name, pdev->id);
> +
> + /* Register MDIO bus */
> + error = of_mdiobus_register(priv->mii_bus, dev->of_node);
> + if (error)
> + goto out_free_bus;
> +
> + return 0;
> +
> +out_free_bus:
> + free_mdio_bitbang(priv->mii_bus);
> + return error;
> +}
> +
> +/* MDIO bus release function */
> +static int ravb_mdio_release(struct ravb_private *priv)
> +{
> + /* Unregister mdio bus */
> + mdiobus_unregister(priv->mii_bus);
> +
> + /* Free bitbang info */
> + free_mdio_bitbang(priv->mii_bus);
> +
> + return 0;
> +}
> +
[...]
> @@ -1887,51 +1942,6 @@ static const struct net_device_ops ravb_netdev_ops = {
> .ndo_set_features = ravb_set_features,
> };
>
> -/* MDIO bus init function */
> -static int ravb_mdio_init(struct ravb_private *priv)
> -{
> - struct platform_device *pdev = priv->pdev;
> - struct device *dev = &pdev->dev;
> - int error;
> -
> - /* Bitbang init */
> - priv->mdiobb.ops = &bb_ops;
> -
> - /* MII controller setting */
> - priv->mii_bus = alloc_mdio_bitbang(&priv->mdiobb);
> - if (!priv->mii_bus)
> - return -ENOMEM;
> -
> - /* Hook up MII support for ethtool */
> - priv->mii_bus->name = "ravb_mii";
> - priv->mii_bus->parent = dev;
> - snprintf(priv->mii_bus->id, MII_BUS_ID_SIZE, "%s-%x",
> - pdev->name, pdev->id);
> -
> - /* Register MDIO bus */
> - error = of_mdiobus_register(priv->mii_bus, dev->of_node);
> - if (error)
> - goto out_free_bus;
> -
> - return 0;
> -
> -out_free_bus:
> - free_mdio_bitbang(priv->mii_bus);
> - return error;
> -}
> -
> -/* MDIO bus release function */
> -static int ravb_mdio_release(struct ravb_private *priv)
> -{
> - /* Unregister mdio bus */
> - mdiobus_unregister(priv->mii_bus);
> -
> - /* Free bitbang info */
> - free_mdio_bitbang(priv->mii_bus);
> -
> - return 0;
> -}
> -
Dave, would you tolerate the forward declarations here instead (to avoid the function moves, to be later
done in the net-next tree)?
[...]
MBR, Sergei
next prev parent reply other threads:[~2020-07-31 18:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 3:56 [PATCH] ravb: Fixed the problem that rmmod can not be done Yuusuke Ashizuka
2020-07-30 7:55 ` kernel test robot
2020-07-30 10:01 ` [PATCH v2] " Yuusuke Ashizuka
2020-07-30 11:37 ` Yoshihiro Shimoda
2020-07-30 16:24 ` Sergei Shtylyov
2020-07-31 6:43 ` Yoshihiro Shimoda
2020-07-31 17:45 ` Sergei Shtylyov
2020-07-30 16:04 ` Sergei Shtylyov
2020-07-31 10:18 ` ashiduka
2020-07-31 16:28 ` Sergei Shtylyov
2020-08-06 2:26 ` ashiduka
2020-07-31 18:32 ` Sergei Shtylyov [this message]
2020-08-06 2:28 ` ashiduka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e7d72fe-ea70-612c-7a50-ad1ff905ddf4@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=ashiduka@fujitsu.com \
--cc=davem@davemloft.net \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).