From: Josh Hunt <johunt@akamai.com>
To: "Samudrala, Sridhar" <sridhar.samudrala@intel.com>,
netdev@vger.kernel.org, willemb@google.com,
intel-wired-lan@lists.osuosl.org
Cc: Alexander Duyck <alexander.h.duyck@intel.com>
Subject: Re: [PATCH 3/3] i40e: Add UDP segmentation offload support
Date: Wed, 9 Oct 2019 17:54:19 -0700 [thread overview]
Message-ID: <0ecadb39-ef96-6802-55f5-f1d72f2132f2@akamai.com> (raw)
In-Reply-To: <5f4af1c5-c2d1-d643-3fb2-fe4bd0e7e8cf@intel.com>
On 10/9/19 5:39 PM, Samudrala, Sridhar wrote:
>
>
> On 10/9/2019 3:06 PM, Josh Hunt wrote:
>> Based on a series from Alexander Duyck this change adds UDP segmentation
>> offload support to the i40e driver.
>>
>> CC: Alexander Duyck <alexander.h.duyck@intel.com>
>> CC: Willem de Bruijn <willemb@google.com>
>> Signed-off-by: Josh Hunt <johunt@akamai.com>
>> ---
>> drivers/net/ethernet/intel/i40e/i40e_main.c | 1 +
>> drivers/net/ethernet/intel/i40e/i40e_txrx.c | 12 +++++++++---
>> 2 files changed, 10 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c
>> b/drivers/net/ethernet/intel/i40e/i40e_main.c
>> index 6031223eafab..56f8c52cbba1 100644
>> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
>> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
>> @@ -12911,6 +12911,7 @@ static int i40e_config_netdev(struct i40e_vsi
>> *vsi)
>> NETIF_F_GSO_IPXIP6 |
>> NETIF_F_GSO_UDP_TUNNEL |
>> NETIF_F_GSO_UDP_TUNNEL_CSUM |
>> + NETIF_F_GSO_UDP_L4 |
>> NETIF_F_SCTP_CRC |
>> NETIF_F_RXHASH |
>> NETIF_F_RXCSUM |
>> diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c
>> b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
>> index e3f29dc8b290..0b32f04a6255 100644
>> --- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c
>> +++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
>> @@ -2960,10 +2960,16 @@ static int i40e_tso(struct i40e_tx_buffer
>> *first, u8 *hdr_len,
>> /* remove payload length from inner checksum */
>> paylen = skb->len - l4_offset;
>> - csum_replace_by_diff(&l4.tcp->check, (__force __wsum)htonl(paylen));
>> - /* compute length of segmentation header */
>> - *hdr_len = (l4.tcp->doff * 4) + l4_offset;
>> + if (skb->csum_offset == offsetof(struct tcphdr, check)) {
>
> Isn't it more relevant to check for gso_type rather than base this on
> the csum_offset?
Thanks Sridhar for the review. Yeah I think you're right. I will change
this on all 3 patches.
Josh
next prev parent reply other threads:[~2019-10-10 0:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 22:06 [PATCH 0/3] igb, ixgbe, i40e UDP segmentation offload support Josh Hunt
2019-10-09 22:06 ` [PATCH 1/3] igb: Add " Josh Hunt
2019-10-09 22:06 ` [PATCH 2/3] ixgbe: " Josh Hunt
2019-10-10 1:06 ` Josh Hunt
2019-10-09 22:06 ` [PATCH 3/3] i40e: " Josh Hunt
2019-10-10 0:39 ` Samudrala, Sridhar
2019-10-10 0:54 ` Josh Hunt [this message]
2019-10-09 22:44 ` [PATCH 0/3] igb, ixgbe, i40e " Alexander Duyck
2019-10-10 21:17 ` Josh Hunt
2019-10-10 21:32 ` Alexander Duyck
2019-10-11 0:07 ` Josh Hunt
2019-10-11 0:21 ` Brown, Aaron F
2019-10-11 0:27 ` Josh Hunt
2019-10-11 0:29 ` Brown, Aaron F
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ecadb39-ef96-6802-55f5-f1d72f2132f2@akamai.com \
--to=johunt@akamai.com \
--cc=alexander.h.duyck@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=sridhar.samudrala@intel.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).