From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0304FC43381 for ; Mon, 18 Feb 2019 11:35:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF1652177E for ; Mon, 18 Feb 2019 11:35:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="H/yBOxCL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729870AbfBRLfx (ORCPT ); Mon, 18 Feb 2019 06:35:53 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:57750 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728915AbfBRLfx (ORCPT ); Mon, 18 Feb 2019 06:35:53 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x1IBXi1Z117073; Mon, 18 Feb 2019 11:35:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=qnFE0ibMCZ2L0+0z8iFLdXu27f0eZZsGWrrmsvbVrIs=; b=H/yBOxCLFDCmTAr5Q6rk5XIdxMMcf/6rM4ibHNHg6tPjZ0Rj9JKF1b1aRbeUnnNXYWyr kBr6eT0jrJrZjY+Mu3UXZkYL3aJNzoMQaEimTW0cGVKQCpb8qO82U0aH8wwZ2DhagScS bcMJiQ56K6qXQDDYY7E8e/VDBrJNIsMbEtv8Pqvgvqezx9FtlB80oBFLY9/rts5NRpg9 qtC0FhHOUhmVZqk3NrUuRTle8vHB6PcBezIOVbzk+RBZN8Q57BVwX4/ZPZRYSU5gFRJ6 qMUgsZ3uxI0Z3VpDi/U2ngvCFojXmbBx0Pg+DybW5wxcI3ziWg2oEIY3iWCX9/I+O7lJ Zw== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2120.oracle.com with ESMTP id 2qpb5r5p3e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 18 Feb 2019 11:35:45 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x1IBZirm005757 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 18 Feb 2019 11:35:44 GMT Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x1IBZi6o017563; Mon, 18 Feb 2019 11:35:44 GMT Received: from [192.168.1.111] (/95.161.223.113) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 18 Feb 2019 03:35:44 -0800 Subject: Re: [PATCH net] sock: return uapi errno in sock_setsockopt() for SO_ZEROCOPY To: Willem de Bruijn Cc: Network Development , Petr Vorel , David Miller References: <1550249574-26772-1-git-send-email-alexey.kodanev@oracle.com> From: Alexey Kodanev Message-ID: <108d9d95-98f4-74b3-f86c-fbd641e1b67b@oracle.com> Date: Mon, 18 Feb 2019 14:35:41 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9170 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=433 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902180089 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 15.02.2019 19:58, Willem de Bruijn wrote: > On Fri, Feb 15, 2019 at 11:51 AM Alexey Kodanev > wrote: >> >> For unsupported protocols, setsockopt() with SO_ZEROCOPY >> option sets errno to ENOTSUPP(524). But this number is >> not defined anywhere in the include/uapi/ headers. >> >> To make sure userspace sees the known number, replace >> ENOTSUPP(524) with EOPNOTSUPP(95). >> >> Fixes: 76851d1212c1 ("sock: add SOCK_ZEROCOPY sockopt") >> Signed-off-by: Alexey Kodanev >> Reported-by: Petr Vorel > > This code has been there since 4.14. I think it's too late to change > system call behavior. > 'ENOTSUPP' define is solely for an internal usage, it may be replaced with another one or the number associated with it may be changed one day, implicitly changing the behavior of setsockopt().