From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A37C4C282C5 for ; Thu, 24 Jan 2019 16:36:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6835D2184C for ; Thu, 24 Jan 2019 16:36:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fMIsKsiC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728662AbfAXQgk (ORCPT ); Thu, 24 Jan 2019 11:36:40 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:42327 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727931AbfAXQgk (ORCPT ); Thu, 24 Jan 2019 11:36:40 -0500 Received: by mail-pg1-f194.google.com with SMTP id d72so2872611pga.9 for ; Thu, 24 Jan 2019 08:36:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0Gs91w84bUEMr6uZ6PTK4D6zuxyReA628tApMsFNSeE=; b=fMIsKsiC9UEM9G05iEEmKDOXQ09Jtk2nwnf+DWbQvAUfBhEHGJQCZp9NL24W0GqoXm 9b7ZE/Jz7v0jIQG3Vsmkn/zj5CJDEn/LBg+eNs9lQw54EDjmJvSZv0nqYw1CMmIL9LbR t0sgwrCmCy/dDREzm34CBqSDaGiIX0Hww/fQjOebihAmXqZwuGn1EQTl7cJ1LKu8S2KP vsSLfFlnnyg3QB1FjwllIEEoO1A7dfrG+pmppgspy2DkKMt6DNe5a62Nv6N4i7i46eUt ja8J9qjEicei4ruKe2fVPAtLSDAH/ezxMUIcARG2bYUMhYPxjefKqIRr8dqcjtqNc9CG j1Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0Gs91w84bUEMr6uZ6PTK4D6zuxyReA628tApMsFNSeE=; b=tGiVRWWzV/EpFOZG+BtV3v1EPV42fVb1D3j4BfHl+qeysv2E5Xs0cYjAixvQhhMSzv b9sXnyBJ/fdN+5jRuugawcFjhqYfojk7ZO/3gAhPRdfhtTLHslSz0Yada1r3LLyWvDqf pD+sNPlqe1Z/eLAkeMlFKJfWnZUCxSQQMEWjXsEppqpNIHSRoaB5RBb8lQFqGuey2OuE zNtXsH81wR7g0JMBGMJQH7tr/xduO3NCtNeHrn4MuzxfCUHuReGM8ZjtU58JfFyre//5 Dx0M29mF7RFjeLiiJnDldE/Ku1RvwxAD0VAV/vGc94jH6M7q5XaUcLLxwmuqypylVAm0 7GCQ== X-Gm-Message-State: AJcUukfZGF1RpJ32it8MET48xghd0/LdP3Q0iKYl+CoAQVu3DIuii96D HWPGD1+HsrDxfO9GRRsCw56HhtGY X-Google-Smtp-Source: ALg8bN78VshAGNmcweomV0rwM+frBsplDNTbDLU0DuUujQzjlEyBGdGDUBwlAPixB/DT8T1i96yykg== X-Received: by 2002:a62:db41:: with SMTP id f62mr7291949pfg.123.1548347798912; Thu, 24 Jan 2019 08:36:38 -0800 (PST) Received: from ?IPv6:2620:15c:2c1:200:55c7:81e6:c7d8:94b? ([2620:15c:2c1:200:55c7:81e6:c7d8:94b]) by smtp.gmail.com with ESMTPSA id n22sm51210398pfh.166.2019.01.24.08.36.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Jan 2019 08:36:37 -0800 (PST) Subject: Re: [PATCH net-next 0/2] tcp_bbr: Improving TCP BBR performance for WiFi and cellular networks To: Priyaranjan Jha , David Miller Cc: netdev@vger.kernel.org References: <20190123200454.260121-1-priyarjha@google.com> From: Eric Dumazet Message-ID: <1099076b-3227-66f6-f58b-302f94b6f8c1@gmail.com> Date: Thu, 24 Jan 2019 08:36:36 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190123200454.260121-1-priyarjha@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 01/23/2019 12:04 PM, Priyaranjan Jha wrote: > Ack aggregation is quite prevalent with wifi, cellular and cable modem > link tchnologies, ACK decimation in middleboxes, and common offloading > techniques such as TSO and GRO, at end hosts. Previously, BBR was often > cwnd-limited in the presence of severe ACK aggregation, which resulted in > low throughput due to insufficient data in flight. > > To achieve good throughput for wifi and other paths with aggregation, this > patch series implements an ACK aggregation estimator for BBR, which > estimates the maximum recent degree of ACK aggregation and adapts cwnd > based on it. The algorithm is further described by the following > presentation: > https://datatracker.ietf.org/meeting/101/materials/slides-101-iccrg-an-update-on-bbr-work-at-google-00 > > (1) A preparatory patch, which refactors bbr_target_cwnd for generic > inflight provisioning. > > (2) Implements BBR ack aggregation estimator and adapts cwnd based > on measured degree of ACK aggregation. > > Priyaranjan Jha (2): > tcp_bbr: refactor bbr_target_cwnd() for general inflight provisioning > tcp_bbr: adapt cwnd based on ack aggregation estimation > > include/net/inet_connection_sock.h | 4 +- > net/ipv4/tcp_bbr.c | 180 +++++++++++++++++++++++++---- > 2 files changed, 161 insertions(+), 23 deletions(-) > Very nice work Priyaranjan Thanks ! Signed-off-by: Eric Dumazet