From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C56CC48BD5 for ; Wed, 26 Jun 2019 01:28:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F67520883 for ; Wed, 26 Jun 2019 01:28:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (4096-bit key) header.d=d-silva.org header.i=@d-silva.org header.b="EAancEyW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726462AbfFZB2P (ORCPT ); Tue, 25 Jun 2019 21:28:15 -0400 Received: from ushosting.nmnhosting.com ([66.55.73.32]:46948 "EHLO ushosting.nmnhosting.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726037AbfFZB2O (ORCPT ); Tue, 25 Jun 2019 21:28:14 -0400 Received: from mail2.nmnhosting.com (unknown [202.169.106.97]) by ushosting.nmnhosting.com (Postfix) with ESMTPS id 723DA2DC0076; Tue, 25 Jun 2019 21:28:11 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=d-silva.org; s=201810a; t=1561512491; bh=97Ya+I+vpFl+/ylzKO5YVmt37vPd4AhTqo0+iiUyHFE=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=EAancEyWaLZKLsqaXUD4dxjOqzDLwe4lEdFjaUlTi0IPpwEjhV2Lo5HHFrHoHBh2g 3MDeWki71oPJXdWUsJWNMYOx8NwJHQt5G3pmWQB5uPepknhUpUhYU0mYJXOBwDiK6A ODDQvsJyAK0AIfYDx3e+IsOTOY7NiAdvATlbPxipbpKq304o7wbTnKpJt0EUaWhn8e sMrKgGepRlTB2n1hCKRdNLkJgZVLQXBGvgA/XI9Z7Mk4SODNPlWoH7HUbrUbYB6t3a DzLfo/OgyaAE08wRoYauv2h+LD5rQhqPCF0v+stxxp4hq5ugyHWnh7GEew5OQPKnTX cIRx/ZrPOQMxal2eJ1J79ak9/Xqc95+dEEj2W5TlCayJ6qdDL1Luzk9j5siHQakecd HlisONDRWhssRGUxa/YJ7248r7KMIi1R6WNO955WFW68WlcZaaAQNvRo+WkbKhnqqd PHbBrJM22zjhIfonkwMmksCc4pycRvJe5PH/jpbbdnhui2wrG6A0Q/ay6ewcb3v+XY s9pyCYwZuY2K1S6TQriWyXgPwBvVkkOZhQIx35frrWoBacHJeNXHSSACxRRi0VdV8h o7ttOA5+FQFRd6i5TqT/JpwzhNRyf2qBzskdYrlE2qP+idDjNSR2mvltiXOnrL51ff OIl4Mj+FZzR5JoYFtWTWvI/U= Received: from adsilva.ozlabs.ibm.com (static-82-10.transact.net.au [122.99.82.10] (may be forged)) (authenticated bits=0) by mail2.nmnhosting.com (8.15.2/8.15.2) with ESMTPSA id x5Q1RmGQ029656 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NO); Wed, 26 Jun 2019 11:28:04 +1000 (AEST) (envelope-from alastair@d-silva.org) Message-ID: <1166c97d5f0ff750e5871937eb1d7e3c0423bbdd.camel@d-silva.org> Subject: Re: [PATCH v4 4/7] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags From: "Alastair D'Silva" To: Joe Perches Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , Dan Carpenter , Karsten Keil , Jassi Brar , Tom Lendacky , "David S. Miller" , Jose Abreu , Kalle Valo , Stanislaw Gruszka , Benson Leung , Enric Balletbo i Serra , "James E.J. Bottomley" , "Martin K. Petersen" , Greg Kroah-Hartman , Alexander Viro , Petr Mladek , Sergey Senozhatsky , Steven Rostedt , David Laight , Andrew Morton , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-scsi@vger.kernel.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-fsdevel@vger.kernel.org Date: Wed, 26 Jun 2019 11:27:48 +1000 In-Reply-To: <3340b520a57e00a483eae170be97316c8d18c22c.camel@perches.com> References: <20190625031726.12173-1-alastair@au1.ibm.com> <20190625031726.12173-5-alastair@au1.ibm.com> <3340b520a57e00a483eae170be97316c8d18c22c.camel@perches.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.2 (3.32.2-1.fc30) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail2.nmnhosting.com [10.0.1.20]); Wed, 26 Jun 2019 11:28:07 +1000 (AEST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 2019-06-24 at 22:01 -0700, Joe Perches wrote: > On Tue, 2019-06-25 at 13:17 +1000, Alastair D'Silva wrote: > > From: Alastair D'Silva > > > > In order to support additional features, rename hex_dump_to_buffer > > to > > hex_dump_to_buffer_ext, and replace the ascii bool parameter with > > flags. > [] > > diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c > > b/drivers/gpu/drm/i915/intel_engine_cs.c > [] > > @@ -1338,9 +1338,8 @@ static void hexdump(struct drm_printer *m, > > const void *buf, size_t len) > > } > > > > WARN_ON_ONCE(hex_dump_to_buffer(buf + pos, len - pos, > > - rowsize, sizeof(u32), > > - line, sizeof(line), > > - false) >= > > sizeof(line)); > > + rowsize, sizeof(u32), > > line, > > + sizeof(line)) >= > > sizeof(line)); > > Huh? Why do this? The ascii parameter was removed from the simple API as per Jani's suggestion. The remainder was reformatted to avoid exceeding the line length limits. > > > diff --git a/drivers/isdn/hardware/mISDN/mISDNisar.c > > b/drivers/isdn/hardware/mISDN/mISDNisar.c > [] > > @@ -70,8 +70,9 @@ send_mbox(struct isar_hw *isar, u8 his, u8 creg, > > u8 len, u8 *msg) > > int l = 0; > > > > while (l < (int)len) { > > - hex_dump_to_buffer(msg + l, len - l, > > 32, 1, > > - isar->log, 256, 1); > > + hex_dump_to_buffer_ext(msg + l, len - > > l, 32, 1, > > + isar->log, 256, > > + HEXDUMP_ASCII); > > Again, why do any of these? > > The point of the wrapper is to avoid changing these. Jani made a pretty good point that about half the callers didn't want an ASCII dump, and presenting a simplified API makes sense. I would actually put forward that we consider dropping rowsize from the simplified API too, as most callers use 32, and those that use 16 would probably be OK with 32. Your proposal, on the other hand, only makes sense if there were many callers, and even so, not in the form that you presented, since that result in a mix of booleans & bitfields that you were critical of. -- Alastair D'Silva mob: 0423 762 819 skype: alastair_dsilva Twitter: @EvilDeece blog: http://alastair.d-silva.org