From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6730FC169C4 for ; Mon, 11 Feb 2019 11:44:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3DCF92070B for ; Mon, 11 Feb 2019 11:44:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726815AbfBKLon (ORCPT ); Mon, 11 Feb 2019 06:44:43 -0500 Received: from dispatch1-us1.ppe-hosted.com ([67.231.154.164]:48884 "EHLO dispatch1-us1.ppe-hosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726041AbfBKLom (ORCPT ); Mon, 11 Feb 2019 06:44:42 -0500 X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 47B14140073; Mon, 11 Feb 2019 11:44:41 +0000 (UTC) Received: from ec-desktop.uk.solarflarecom.com (10.17.20.45) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 11 Feb 2019 03:44:37 -0800 Subject: Re: TC stats / hw offload question To: Jamal Hadi Salim , netdev CC: Jiri Pirko , Cong Wang , "Or Gerlitz" , Andy Gospodarek , "PJ Waskiewicz" , Anjali Singhai Jain , Jakub Kicinski References: <26f0cfc9-3bef-8579-72cc-aa6c5ccecd43@solarflare.com> <4cb765dd-453f-3139-bce6-6e0b31167aec@mojatatu.com> <70d77198-42fd-838a-d352-2647e7cad4d6@solarflare.com> <561205a6-101b-c86b-e77d-6ebdcf31a56d@mojatatu.com> From: Edward Cree Message-ID: <11ab2dc0-ec39-18cd-d170-0d5f954198b9@solarflare.com> Date: Mon, 11 Feb 2019 11:44:35 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <561205a6-101b-c86b-e77d-6ebdcf31a56d@mojatatu.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB X-Originating-IP: [10.17.20.45] X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24422.005 X-TM-AS-Result: No-6.083900-4.000000-10 X-TMASE-MatchedRID: L8tZF6zWW2oOwH4pD14DsPHkpkyUphL9zjEhISWZSrVjyv+d0Z0Oxc3q hpIE26kvGfUFO8gxoAd9WLc/vDC7OCtpu5EmsZp29Ib/6w+1lWT4h+uI7dxXxJ3BT+pdjEe8BK6 s6YP1BlqaT776wU7KZO8rlYNPyq+Ek+495TouE0M1yhbbA7We00Crr/LkAQ46NE5yhKhaSOrRXO samVbRj3XizeGcQrBrLDn/kh7QodWdCZFhy/n8WSTJO8aPdqAlncKJki+ooR2bKItl61J/yUjQx nYacsX5eDdY4UVUBS3CttcwYNipX/k39LXMSri6IOVXHxdBR5jBVSfzcRCoxi8c+xlplOzJpjZC eYSvgtE= X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--6.083900-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24422.005 X-MDID: 1549885482-ah_7EKryupyC Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 09/02/19 17:39, Jamal Hadi Salim wrote: > On 2019-02-08 5:26 a.m., Edward Cree wrote: >>   I can't find any stats counters on >>   the "match" either in the software path or the offload API. > > Hasnt been necessary thus far. > Is your end goal to match and count? My end goal is to implement TC offload in some hw we're designing  here at Solarflare.  So I'm trying to determine what hardware is  expected/required to do. It might be possible to design our new hw so that we can attach a  counter to every action, if that's what TC wants.  But since the  other vendors don't seem to do that, I wondered if there was a  reason, or if perhaps the counter resources (and PCI bw to read  them) could be saved if all those separate counters aren't really  needed.  Right now the design we are considering would only count  packets as-matched, i.e. before any edits.  That's fine for encap  — you can calculate the bytes correction in SW — but not for decap  since in principle the length of the RXed outer headers could  vary (e.g. you might have IP options there). -Ed