From: Heiner Kallweit <hkallweit1@gmail.com>
To: Vincas Dargis <vindrg@gmail.com>,
Salvatore Bonaccorso <carnil@debian.org>
Cc: netdev@vger.kernel.org
Subject: Re: About r8169 regression 5.4
Date: Fri, 21 Feb 2020 22:01:16 +0100 [thread overview]
Message-ID: <11c9c70f-5192-9f02-c622-f6e03db7dfb2@gmail.com> (raw)
In-Reply-To: <86a87b0e-0a5b-46c7-50f5-5395a0de4a52@gmail.com>
On 21.02.2020 21:21, Vincas Dargis wrote:
> 2020-02-20 20:32, Heiner Kallweit rašė:
>> It would be great if you could test one more thing. Few chip versions have a hw issue with tx checksumming
>> for very small packets. Maybe your chip version suffers from the same issue.
>> Could you please test the following patch (with all features enabled, TSO and checksumming)?
>>
>> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
>> index 8442b8767..bee90af57 100644
>> --- a/drivers/net/ethernet/realtek/r8169_main.c
>> +++ b/drivers/net/ethernet/realtek/r8169_main.c
>> @@ -4345,6 +4345,7 @@ static netdev_features_t rtl8169_features_check(struct sk_buff *skb,
>> case RTL_GIGA_MAC_VER_12:
>> case RTL_GIGA_MAC_VER_17:
>> case RTL_GIGA_MAC_VER_34:
>> + case RTL_GIGA_MAC_VER_44:
>> features &= ~NETIF_F_CSUM_MASK;
>> break;
>> default:
>>
>
> Sadly, network got hanged after ~1.5h of usage. I've built it with Debian's "debian/bin/test-patches" helper (kernel is now named 5.4.19-1a~test),
> double-checked that line was actually added in source. `ethtool -K enp5s0f1 tx on sg on tso on` was executed after boot.
OK, thanks anyway for testing. I forwarded your testing results with Realtek's r8168 driver to Realtek,
let's see whether they can identify the root cause of the problem.
next prev parent reply other threads:[~2020-02-21 21:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 17:21 About r8169 regression 5.4 Vincas Dargis
2020-02-14 20:14 ` Heiner Kallweit
2020-02-15 9:22 ` Vincas Dargis
2020-02-15 16:12 ` Salvatore Bonaccorso
2020-02-15 21:10 ` Vincas Dargis
2020-02-15 22:07 ` Vincas Dargis
2020-02-15 22:35 ` Heiner Kallweit
2020-02-15 23:27 ` Heiner Kallweit
2020-02-17 18:08 ` Vincas Dargis
2020-02-17 19:59 ` Heiner Kallweit
2020-02-18 18:36 ` Vincas Dargis
2020-02-19 21:54 ` Heiner Kallweit
2020-02-20 17:36 ` Vincas Dargis
2020-02-20 18:32 ` Heiner Kallweit
2020-02-21 20:21 ` Vincas Dargis
2020-02-21 21:01 ` Heiner Kallweit [this message]
2020-02-23 13:24 ` Vincas Dargis
2020-02-23 13:27 ` Heiner Kallweit
2020-02-24 19:49 ` Heiner Kallweit
2020-02-27 18:25 ` Vincas Dargis
2020-04-12 11:56 ` Lauri Jakku
2020-04-12 12:02 ` Lauri Jakku
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11c9c70f-5192-9f02-c622-f6e03db7dfb2@gmail.com \
--to=hkallweit1@gmail.com \
--cc=carnil@debian.org \
--cc=netdev@vger.kernel.org \
--cc=vindrg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).